Repository navigation
fix(mobile): correct the privacy sheet's voice transcription and gateway claims - #6196
Conversation
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryFull re-review of the rebased privacy-sheet copy change at Files Reviewed (91 files)
Previous Review Summaries (3 snapshots, latest commit 0e70956)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 0e70956)Status: No Issues Found | Recommendation: Merge Executive SummaryFull re-review of the rebased privacy-sheet change (the previous review SHA is no longer an ancestor, so the whole PR diff was re-analyzed; the PR-authored patch itself is unchanged) found no bugs, security problems, or regressions on the changed lines. Files Reviewed (91 files)
Previous review (commit 755fc9f)Status: No Issues Found | Recommendation: Merge Files Reviewed (91 files)
Incremental re-review at Previous review (commit b8f2f8b)Status: No Issues Found | Recommendation: Merge Reviewed the privacy-sheet copy correction and the new voice-status precedence end to end. The new Files Reviewed (91 files)
Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
b8f2f8b to
755fc9f
Compare
755fc9f to
0e70956
Compare
b482a07 to
2275bf7
Compare
Changelog for users
Changelog for maintainers
voiceTranscriptionWho).gatewayWhat); it previously named only account ID, request metadata and token usage.viaGatewaykey ("Via the Kilo gateway") fills the voice footer status row when gateway transcription is on; the engine is chosen in Preferences, so that row carries no switch.useCurrentUserIdexposes an additiveisFetchError: a failed fetch with a cached identity still reports the failure, whileisErrorkeeps the signed-in state.consent-details.tsx; the account read gates every claim.en.json.E2E proof
[e1] Retryable unhappy (needs:fault) — sheet voice row shows 'Could not load your transcription setting.' with Retry when the API is unreachable — android emulator-5554, STATE HIT signed-in-home; with nextjs killed (e1-fault-down.log 'fault.sh: nextjs killed (port 7300 refuses; pids 208836 )') a freshly mounted privacy sheet's voice row showed 'android.widget.TextView Could not load your transcription setting. tappable [55,1782][1025,1828]' beside 'android.widget.Button Retry tappable [55,1846][1025,1962]' with zero 'On device' lines (e1-fault-mount-digest.log, e1-fault-row.xml); 'ASSERT HIT Could not load your transcription setting. matches=1'/'ASSERT HIT Retry matches=2' (e1-fault-mount.log); after nextjs up and Retry, 'ASSERT HIT On…
[e1] Retryable unhappy (needs:fault) — sheet voice row shows 'Could not load your transcription setting.' with Retry when the API is unreachable
/home/igor_kilocode_ai/.local/share/kwf/sections/kwf-fix-proof-2275bf7-336e/e2e-backend/backend.log/home/igor_kilocode_ai/.local/share/kwf/sections/kwf-fix-proof-2275bf7-336e/e2e-mobile-app/e1-fault-down.log/home/igor_kilocode_ai/.local/share/kwf/sections/kwf-fix-proof-2275bf7-336e/e2e-mobile-app/e1-fault-mount-digest.log/home/igor_kilocode_ai/.local/share/kwf/sections/kwf-fix-proof-2275bf7-336e/e2e-mobile-app/e1-fault-mount.log/home/igor_kilocode_ai/.local/share/kwf/sections/kwf-fix-proof-2275bf7-336e/e2e-mobile-app/e1-recovery.logOwner request
Open findings (not fixed here)
p6-coldstart.mp4