Skip to content

fix(cloud-agent-next): disable Kilo snapshots in cloud agent - #6183

Merged
eshurakov merged 2 commits into
mainfrom
kilo/bold-dale-plm
Sep 16, 2026
Merged

eshurakov merged 2 commits into
mainfrom
kilo/bold-dale-plm

Conversation

@kilo-code-bot

@kilo-code-bot kilo-code-bot Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Summary

Cloud Agent sessions now always generate the Kilo CLI config with snapshot: false. Previously snapshots were enabled only for web-originated sessions (createdOnPlatform === 'cloud-agent-web'); every other origin already had them off. This makes the setting unconditional so no Cloud Agent session runs Kilo's snapshot feature.

The flag is written into both KILO_CONFIG_CONTENT and OPENCODE_CONFIG_CONTENT in SessionService.buildWrapperSessionReadyAndPromptRequests.

Verification

No manual sandbox run was performed; this is a config-only change. The existing unit test that asserted snapshot: true for cloud-agent-web was updated to assert false for all origins and was run locally.

  • Run a Cloud Agent session and confirm the generated KILO_CONFIG_CONTENT contains "snapshot": false.

Visual Changes

N/A

Reviewer Notes

  • Behavior change: cloud-agent-web sessions previously enabled snapshots; they no longer do.
  • Covered by services/cloud-agent-next/src/session-service.test.ts (disables Kilo snapshots for %s-origin sessions).
  • Change site: services/cloud-agent-next/src/session-service.ts:1512.

Comment thread services/cloud-agent-next/src/session-service.ts
@kilo-code-bot

kilo-code-bot Bot commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor Author

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Executive Summary

Incremental review of 422a6ff83 confirms the previously flagged snapshot-initialization contradiction is resolved: the wrapper-side snapshotInitialization: 'wait' wait, its kilo-api.ts option, and the corresponding tests were removed, leaving no dangling references and consistent with the unconditional snapshot: false config.

Files Reviewed (5 files)
  • services/cloud-agent-next/src/session-service.test.ts
  • services/cloud-agent-next/test/unit/wrapper/kilo-api.test.ts
  • services/cloud-agent-next/test/unit/wrapper/server.test.ts
  • services/cloud-agent-next/wrapper/src/kilo-api.ts
  • services/cloud-agent-next/wrapper/src/server.ts
Previous Review Summary (commit b2ae1a1)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit b2ae1a1)

Status: 1 Issue Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 1
SUGGESTION 0
Issue Details (click to expand)

WARNING

File Line Issue
services/cloud-agent-next/src/session-service.ts 1512 snapshot: false is now unconditional, but the wrapper still sends snapshotInitialization: 'wait' for cloud-agent-web (wrapper/src/server.ts:191, 553, 671). The config disable and the request-level wait now contradict each other; drop the wrapper wait or confirm the CLI ignores it when snapshots are disabled.
Files Reviewed (2 files)
  • services/cloud-agent-next/src/session-service.ts - 1 issue
  • services/cloud-agent-next/src/session-service.test.ts - 0 issues (test update correctly asserts snapshot === false for all five origins; the it.each rework is sound)

Fix these issues in Kilo Cloud


Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0

Review guidance: REVIEW.md from base branch main

@eshurakov eshurakov self-assigned this Sep 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants