fix(mobile): enlarge icon-only touch targets to 44pt - #6101
Merged
Conversation
Surface: the mobile app (apps/mobile).
# Problem
Two icon-only controls on the mobile app fall below the app's own 44pt touch-target convention, making them harder to hit (the device-sessions control is destructive).
- `apps/mobile/src/components/device-sessions-screen.tsx:61-76`: the sign-out control rendered as `<LogOut size={16} />` inside a `Pressable` has `className="shrink-0 active:opacity-70"` and `hitSlop={8}`, so its effective touch area is roughly 32x32pt (16pt glyph + 8pt slop per side), well under the 44pt the app uses elsewhere.
- `apps/mobile/src/components/image-viewer-modal.tsx:180-199`: the close and share controls are `h-10 w-10` (40pt) with no `hitSlop`, so both stay under 44pt.
The intended pattern already exists in this codebase: `apps/mobile/src/components/trusted-hosts-screen.tsx:68-78` gives the same style of trailing icon action `className="min-h-11 min-w-11 shrink-0 items-center justify-center active:opacity-70"`, and `apps/mobile/src/components/ui/button.tsx:22-31` documents 44pt as the minimum for the `icon` size. `apps/mobile/src/components/sheet-header.tsx:66-79,110-118` uses the same `min-h-11 min-w-11` treatment for icon-only sheet controls.
# Requested behavior
Make the device-sessions sign-out control and the image-viewer close/share controls meet the same 44pt minimum as the existing icon controls, without changing the visible glyph sizes or the surrounding layout intent.
- In `apps/mobile/src/components/device-sessions-screen.tsx`, g
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge The PR raises the device-sessions sign-out and image-viewer close/share touch targets to a 44pt minimum using the repo's established Files Reviewed (4 files)
Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
eshurakov
approved these changes
Sep 14, 2026
iscekic
deleted the
kwf/janitor-2026-09-12-experience-and-design-14e1
branch
September 14, 2026 13:10
This was referenced Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog for users
Changelog for maintainers
device-sessions-screen.tsx: the sign-outPressableusesmin-h-[44px] min-w-[44px] shrink-0 items-center justify-center;hitSlop={8}is unchanged, so the effective area is larger than the visible 44pt box.image-viewer-modal.tsx: the close and sharePressables swaph-10 w-10formin-h-[44px] min-w-[44px] shrink-0; neither has hit slop, so the box itself must provide the 44pt minimum.[44px]rather than the requestedmin-h-11 min-w-11: the native rem is 14pt, somin-h-11resolves to 38.5pt, under the app's minimum. The px form matchesbutton.tsx'siconsize.Skeletonin a 44x44View, so the skeleton row and the loaded row have the same height.shrink-0on both new boxes prevents the controls from reflowing when the title grows.image-viewer-modal.mounted.test.tsxadds a close/share 44px assertion;device-sessions-screen.mounted.test.tsxasserts the 44px class names,hitSlop8, and three reserved skeleton boxes.trusted-hosts-screen.tsxstill usesmin-h-11 min-w-11, which resolves below 44pt natively; it is left unchanged as out of scope.E2E proof
Recording of the verified flow (waits trimmed)
e1-devsess.mp4.trim.mp4
Recording of the verified flow (waits trimmed)
e1-viewer.mp4.trim.mp4
Recording of the verified flow (waits trimmed)
e1-load.mp4.trim.mp4
Recording of the verified flow (waits trimmed)
p3-share.mp4.trim.mp4
Recording of the verified flow (waits trimmed)
p2-run.mp4.trim.mp4
Recording of the verified flow (waits trimmed)
p3-share-flow.mp4.trim.mp4
E2E proof — log excerpts
/home/igor_kilocode_ai/.local/share/kwf/sections/janitor-2026-09-12-experience-and-design-14e1/e2e-mobile-app/e1-devsess-layout.log/home/igor_kilocode_ai/.local/share/kwf/sections/janitor-2026-09-12-experience-and-design-14e1/e2e-mobile-app/e1-viewer.log/home/igor_kilocode_ai/.local/share/kwf/sections/janitor-2026-09-12-experience-and-design-14e1/e2e-mobile-app/p4-signout.log/home/igor_kilocode_ai/.local/share/kwf/sections/janitor-2026-09-12-experience-and-design-14e1/e2e-mobile-app/p1.logOwner request