Skip to content

feat(cloud-agent-next): allow workspace backups without setup commands - #6065

Merged
eshurakov merged 1 commit into
mainfrom
eshurakov/amber-maple
Sep 10, 2026
Merged

feat(cloud-agent-next): allow workspace backups without setup commands#6065
eshurakov merged 1 commit into
mainfrom
eshurakov/amber-maple

Conversation

@eshurakov

Copy link
Copy Markdown
Contributor

What

Workspace repo snapshots (buildWorkspaceBackupCandidate) required a non-empty setupCommands list. Sessions that only clone a repository — for example code reviews resolved from an explicit profile — therefore never populated or reused the prepared-workspace cache.

This removes that gate. Setup commands remain part of the cache fingerprint, so sessions with different setup recipes keep distinct entries and cannot share a snapshot.

Verification

  • pnpm exec vitest run src/workspace-backup-cache.test.ts — 24 passed
  • pnpm exec vitest run src/agent-sandbox/cloudflare/cloudflare-agent-sandbox.test.ts — 51 passed
  • oxlint on the changed files — clean
  • oxfmt --check on the changed files — clean
  • tsgo --noEmit — clean

Note: unit tests only. No end-to-end run of a session/code review with snapshots enabled.

Workspace backups required a non-empty setup command list, so sessions
that only clone a repository (for example code reviews resolved from an
explicit profile) never populated or reused the prepared-workspace cache.

Drop the setup-command gate. Setup commands remain part of the cache
fingerprint, so sessions with different setup recipes keep distinct
entries.
@kilo-code-bot

kilo-code-bot Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (2 files)
  • services/cloud-agent-next/src/workspace-backup-cache.ts
  • services/cloud-agent-next/src/workspace-backup-cache.test.ts

Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0

Review guidance: REVIEW.md from base branch main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants