feat(cloud-agent-next): allow workspace backups without setup commands - #6065
Merged
Conversation
Workspace backups required a non-empty setup command list, so sessions that only clone a repository (for example code reviews resolved from an explicit profile) never populated or reused the prepared-workspace cache. Drop the setup-command gate. Setup commands remain part of the cache fingerprint, so sessions with different setup recipes keep distinct entries.
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
pandemicsyn
approved these changes
Sep 10, 2026
This was referenced Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Workspace repo snapshots (
buildWorkspaceBackupCandidate) required a non-emptysetupCommandslist. Sessions that only clone a repository — for example code reviews resolved from an explicit profile — therefore never populated or reused the prepared-workspace cache.This removes that gate. Setup commands remain part of the cache fingerprint, so sessions with different setup recipes keep distinct entries and cannot share a snapshot.
Verification
pnpm exec vitest run src/workspace-backup-cache.test.ts— 24 passedpnpm exec vitest run src/agent-sandbox/cloudflare/cloudflare-agent-sandbox.test.ts— 51 passedoxlinton the changed files — cleanoxfmt --checkon the changed files — cleantsgo --noEmit— cleanNote: unit tests only. No end-to-end run of a session/code review with snapshots enabled.