Skip to content

fix(mobile): align centered-header caret, cap composers, fix live activity locale - #6049

Merged
iscekic merged 3 commits into
mainfrom
fix/mobile-pass-composer-header-activity
Sep 10, 2026
Merged

fix(mobile): align centered-header caret, cap composers, fix live activity locale#6049
iscekic merged 3 commits into
mainfrom
fix/mobile-pass-composer-header-activity

Conversation

@iscekic

@iscekic iscekic commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Center the ScreenHeader title and its leading control on one row. The caret no longer draws below the title. This fixes the class of issue where a centered or modal header put the back control on its own row.
  • Cap the agent chat composer input at 124pt and the new-session prompt at 160pt, scaled by font size. The remaining-space cap alone let the input fill a tall window.
  • Remove the fixed width caps on the model chip. The chip uses the available row width and ellipsis-izes only when the model name is too long.
  • Name the Latin script in the iOS Live Activity locale for Serbian (sr_Latn). The relative timer uses the same script as the rest of the text.

Verification

  • Ran pnpm format, pnpm typecheck, pnpm lint, pnpm check:unused, pnpm check:classes in apps/mobile.
  • Ran pnpm vitest run; all 9455 tests pass.
  • Ran no manual device tests. The changes are layout and locale formatting only.

Visual Changes

Screenshots are in the issue. No device build ran.

Reviewer Notes

  • resolveComposerMaxHeight now takes absoluteMaxHeight. The two callers pass the restored 124/160pt caps.
  • Serbian is the only app language whose catalog script differs from its bare tag. The locale map handles the class, not only Serbian.

@iscekic iscekic self-assigned this Sep 10, 2026
@kilo-code-bot

kilo-code-bot Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Executive Summary

Incremental review of the catalog-script locale test and layout-copy test cleanup found no runtime or logic issues.

Files Reviewed (9 files)
  • apps/mobile/src/components/agents/chat-composer-input-height.test.ts
  • apps/mobile/src/components/agents/chat-composer-input-height.ts
  • apps/mobile/src/components/agents/chat-composer.tsx
  • apps/mobile/src/components/agents/model-selector.tsx
  • apps/mobile/src/components/agents/new-session-prompt.tsx
  • apps/mobile/src/components/screen-header.mounted.test.tsx
  • apps/mobile/src/components/screen-header.tsx
  • apps/mobile/src/glanceable-ios/layout-copy.ts
  • apps/mobile/src/glanceable-ios/layout-locale-script.test.ts
Previous Review Summary (commit 801febf)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit 801febf)

Status: No Issues Found | Recommendation: Merge

Executive Summary

Reviewed nine mobile files for centered ScreenHeader layout, composer height caps, model-chip width, and Serbian Live Activity locale; no runtime or logic issues found.

Files Reviewed (9 files)
  • apps/mobile/src/components/agents/chat-composer-input-height.test.ts
  • apps/mobile/src/components/agents/chat-composer-input-height.ts
  • apps/mobile/src/components/agents/chat-composer.tsx
  • apps/mobile/src/components/agents/model-selector.tsx
  • apps/mobile/src/components/agents/new-session-prompt.tsx
  • apps/mobile/src/components/screen-header.mounted.test.tsx
  • apps/mobile/src/components/screen-header.tsx
  • apps/mobile/src/glanceable-ios/layout-copy.test.ts
  • apps/mobile/src/glanceable-ios/layout-copy.ts

Reviewed by grok-4.6 · Input: 219K · Output: 11.9K · Cached: 120.1K

Review guidance: REVIEW.md from base branch main

@iscekic iscekic added the human-ready The PR is ready for human review. label Sep 10, 2026
@iscekic
iscekic enabled auto-merge (squash) September 10, 2026 13:03
…ser-header-activity

# Conflicts:
#	apps/mobile/src/components/screen-header.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

human-ready The PR is ready for human review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants