fix(mobile): align centered-header caret, cap composers, fix live activity locale - #6049
Merged
Merged
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryIncremental review of the catalog-script locale test and layout-copy test cleanup found no runtime or logic issues. Files Reviewed (9 files)
Previous Review Summary (commit 801febf)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 801febf)Status: No Issues Found | Recommendation: Merge Executive SummaryReviewed nine mobile files for centered ScreenHeader layout, composer height caps, model-chip width, and Serbian Live Activity locale; no runtime or logic issues found. Files Reviewed (9 files)
Reviewed by grok-4.6 · Input: 219K · Output: 11.9K · Cached: 120.1K Review guidance: REVIEW.md from base branch |
eshurakov
approved these changes
Sep 10, 2026
iscekic
enabled auto-merge (squash)
September 10, 2026 13:03
…ser-header-activity # Conflicts: # apps/mobile/src/components/screen-header.tsx
This was referenced Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ScreenHeadertitle and its leading control on one row. The caret no longer draws below the title. This fixes the class of issue where a centered or modal header put the back control on its own row.sr_Latn). The relative timer uses the same script as the rest of the text.Verification
pnpm format,pnpm typecheck,pnpm lint,pnpm check:unused,pnpm check:classesinapps/mobile.pnpm vitest run; all 9455 tests pass.Visual Changes
Screenshots are in the issue. No device build ran.
Reviewer Notes
resolveComposerMaxHeightnow takesabsoluteMaxHeight. The two callers pass the restored 124/160pt caps.