fix(cloud-agent-next): stop deploy from wiping control-plane enrollment - #6044
Merged
eshurakov merged 1 commit intoSep 10, 2026
Merged
Conversation
Omit CONTROL_PLANE_IDS and WORKTREE_CREATION_ENABLED_IDS from production wrangler vars so dashboard allowlists survive deploy, matching PER_SESSION_SANDBOX_ORG_IDS. Keep wrangler dev and .dev.vars.example defaulted to *.
Contributor
Author
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryOmitting production wrangler enrollment vars matches the existing dashboard-preserve pattern and fail-closed runtime, with high confidence. Files Reviewed (5 files)
Reviewed by grok-4.6 · Input: 58.4K · Output: 8.7K · Cached: 349.2K Review guidance: REVIEW.md from base branch |
iscekic
approved these changes
Sep 10, 2026
eshurakov
deleted the
fix/cloud-agent-next-dashboard-control-plane-vars
branch
September 10, 2026 09:20
This was referenced Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CONTROL_PLANE_IDSandWORKTREE_CREATION_ENABLED_IDSfrom productionwrangler.jsoncvars so Cloudflare dashboard allowlists survive deploy (same pattern asPER_SESSION_SANDBOX_ORG_IDS).devand.dev.vars.exampledefaulted to*so local control-plane and worktree creation stay enabled.Test plan
pnpm exec vitest run src/callbacks/queue-config.test.tsinservices/cloud-agent-next