(janitor/dead-code): remove unused code-review platform prompt helpers - #6041
Merged
Merged
Conversation
Delete getCliTool, getPrTerm, replacePlatformPlaceholders, and PLATFORM_TERMINOLOGY from code-reviews/prompts/platform-helpers.ts. None are referenced anywhere in the repository (source, tests, configs, docs, or prompt templates) or by the external Kilo-Org/kilocode consumer.
Contributor
Author
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (1 files)
Reviewed by grok-4.6 · Input: 82.7K · Output: 3.5K · Cached: 123.9K Review guidance: REVIEW.md from base branch |
pandemicsyn
approved these changes
Sep 11, 2026
This was referenced Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was deleted
Removed four exported symbols from
apps/web/src/lib/code-reviews/prompts/platform-helpers.ts:getCliTool(platform)— returned the platform CLI name (gh/glab/bb)getPrTerm(platform)— returned the PR/MR term (PR/MR)replacePlatformPlaceholders(text, platform, values)— replaced{CLI},{PR_TERM},{REPO},{PR_NUMBER}, etc. placeholdersPLATFORM_TERMINOLOGY— platform terminology map102 lines removed.
getPlatformConfig, thePlatformConfigtype, and the three per-platform config objects are retained because they remain reachable and in use.Evidence of unreachability
.ts,.tsx,.md,.json, tests,.specs, CI workflows) return only their own definitions.generate-prompt.ts, which imports onlygetPlatformConfig.export *re-exports the file or these symbols (nopromptsindex re-export exists).import()/require()of the file path exists.Kilo-Org/kilocodecontains no reference to these symbols (this is internalapps/webcode, not a published package, so no external contract is involved).Entry points checked
jest.mock/requireActualthese symbols; the onlyplatform-helpers.test.tsbelongs to a different file (src/lib/bot/platform-helpers.ts).default-prompt-template*.jsonuse{PR_NUMBER}/{MR_IID}/{BASE_SHA}/{HEAD_SHA}placeholders handled inline ingenerate-prompt.ts/prepare-review-payload.ts; they do not use the{CLI}/{PR_TERM}placeholders this helper existed to substitute.apps/webis a Vercel Next.js app with no Wrangler bindings or Durable Objects involved.Contract and compatibility
apps/webcode; no packageexports, SDK, CLI, or plugin surface affected.constobject).Validation
tsgo --noEmit -p apps/web/tsconfig.json— passes (exit 0).oxlint --config .oxlintrc.jsonon the file — 0 warnings, 0 errors.oxfmt --checkon the file — clean;git diff --checkclean.apps/webprompt unit tests (jest src/lib/code-reviews/prompts) could not run in this environment because their shared setup requires a live PostgreSQL instance (not available here), which is expected and unrelated to this change.