Respect the per-repo override for the model selection - #6001
Merged
Merged
Conversation
If the user has chosen a different model for a github repository, switch out the model once the repository is known The initial inference to determine the repository and other setup still uses the users default model for their integration
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (3 files)
Previous Review Summary (commit 43ae937)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 43ae937)Status: No Issues Found | Recommendation: Merge Files Reviewed (10 files)
Reviewed by grok-4.6 · Input: 101K · Output: 6.1K · Cached: 290.9K Review guidance: REVIEW.md from base branch |
pandemicsyn
approved these changes
Sep 9, 2026
This was referenced Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the user has chosen a different model for a github repository, switch out the model once the repository is known
The initial inference to determine the repository and other setup still uses the users default model for their integration
Summary
Note: I decided explicitly against wiring this into the UI for the New Cloud Agent session. That modal almost always prefers the user's most recent model (unless it's their first experience). I didn't want to create confusion about user expectations (should it always switch away, what happens if the user overrides it etc), so the simplest thing was to leave this alone for now. Instead the scenarios affected are:
Verification
Testing this locally isn't easy, since it's realistically triggered from an
@mentionand not e.g. the new cloud agent page. That tab always has the user's last model as the sticky one, and I don't want to change it. So, unit tests only for now