feat(mobile): persist last Run-on destination - #5988
Merged
Merged
Conversation
Restore the last new-agent destination after instances load. If that destination is gone, use Cloud Agent.
iscekic
enabled auto-merge (squash)
September 9, 2026 09:41
| key: LAST_RUN_ON_DESTINATION_KEY, | ||
| defaultValue: null, | ||
| parse: parseStoredRunOnDestination, | ||
| serialize: value => value ?? '', |
Contributor
There was a problem hiding this comment.
WARNING: Empty SecureStore values fail on iOS, so picking Cloud Agent will not persist
serialize writes '' when the user selects Cloud Agent (saveRunOn(null)). iOS Keychain / expo-secure-store reject empty values, so the write fails (error toast) and the previous CLI connection id stays on disk. On the next visit, restore still selects that CLI.
Use a non-empty sentinel, or store.clear() when the destination is Cloud Agent.
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
Contributor
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (8 files)
Fix these issues in Kilo Cloud Reviewed by grok-4.6 · Input: 254.8K · Output: 15.1K · Cached: 648.2K Review guidance: REVIEW.md from base branch |
eshurakov
approved these changes
Sep 9, 2026
This was referenced Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last Run-on pick on the new-agent page is now the default.