Skip to content

fix(mobile): poll in-progress org review transcripts - #5985

Merged
iscekic merged 4 commits into
mainfrom
fix/mobile-org-review-live-transcript
Sep 9, 2026
Merged

fix(mobile): poll in-progress org review transcripts#5985
iscekic merged 4 commits into
mainfrom
fix/mobile-org-review-live-transcript

Conversation

@iscekic

@iscekic iscekic commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Review and merge #5985.

An in-progress org code-review transcript now loads. A finished transcript already loaded.

  • Org reviews run as bot-owned sessions. A stream ticket is creator-only (web fix(code-reviews): restore live review transcripts #5781).
  • The mobile spectator used a websocket for every in-flight v2 review, so org members got 403 and an empty live log.
  • In-flight org reviews now poll getSessionMessages every 2s, same as web.
  • Personal in-flight reviews still use the live socket.
  • An empty poll does not wipe the last non-empty snapshot.

Test

  • pnpm --filter kilo-app exec vitest run src/components/code-reviewer/review-spectator-behavior.test.ts src/components/code-reviewer/review-detail-screen.mounted.test.tsx
  • 50 tests passed. Lint and typecheck passed.

Org code reviews run as bot-owned sessions. A stream ticket is creator-only.
Poll getSessionMessages while an org review runs. Keep the personal live socket.
@iscekic iscekic self-assigned this Sep 8, 2026
@kilo-code-bot

kilo-code-bot Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (1 files)
  • apps/mobile/src/components/code-reviewer/review-spectator-behavior.ts
Previous Review Summaries (2 snapshots, latest commit 7d9f8de)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit 7d9f8de)

Status: No Issues Found | Recommendation: Merge

Files Reviewed (1 files)
  • apps/mobile/src/components/code-reviewer/review-spectator-behavior.ts

Previous review (commit 2cbd83d)

Status: No Issues Found | Recommendation: Merge

Files Reviewed (5 files)
  • apps/mobile/src/components/code-reviewer/review-spectator-behavior.ts
  • apps/mobile/src/components/code-reviewer/review-spectator-live.ts
  • apps/mobile/src/components/code-reviewer/review-spectator.tsx
  • apps/mobile/src/components/code-reviewer/review-spectator-behavior.test.ts
  • apps/mobile/src/components/code-reviewer/review-detail-screen.mounted.test.tsx

Reviewed by grok-4.6 · Input: 129.6K · Output: 5.9K · Cached: 284.5K

Review guidance: REVIEW.md from base branch main

knip check-unused failed on PR 5985 because the set is file-local.
@iscekic
iscekic enabled auto-merge (squash) September 9, 2026 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants