feat(auth): mobile and remaining scoped-token consumers - #5976
feat(auth): mobile and remaining scoped-token consumers#5976pandemicsyn wants to merge 15 commits into
Conversation
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryThe follow-up commit extracts Security Auto Analysis into a separate PR, reverting the Files Reviewed (15 files)
Previous Review Summaries (5 snapshots, latest commit 0161d1c)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 0161d1c)Status: No Issues Found | Recommendation: Merge Executive SummaryThe follow-up commit extracts Gastown and Webhook Agent Ingest issuance into separate PRs, reverting those branches to Files Reviewed (3 files)
Previous review (commit edde179)Status: No Issues Found | Recommendation: Merge Executive SummaryThe four follow-up commits since the previous review (mobile legacy-token behavior with native adoption off, remaining-family consumer contracts, Gastown pepper/runtime-renewal fencing, and rollout docs) were inspected in full; no new defects were found in the changed code. Files Reviewed (39 files)
Previous review (commit 4ccf1ff)Status: No Issues Found | Recommendation: Merge Files Reviewed (109 files)
Previous review (commit 7a29996)Status: No Issues Found | Recommendation: Merge Files Reviewed (10 files)
Previous review (commit 287ed27)Status: 3 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (109 files)
Reviewed by deepseek-v4.1-flash · Input: 46.3K · Output: 8.3K · Cached: 501.9K Review guidance: REVIEW.md from base branch |
58fb880 to
4ccf1ff
Compare
Summary
Add gated scoped-token issuance for native/mobile, Chat/Events/Notifications, Wasteland, and benchmark.
Mobile retains legacy login, refresh, storage, and request authentication when native adoption is off, including when the shared Web master is on. Negotiated bundles select API/gateway credentials for model and voice requests. No pepper initialization or rotation is introduced. Benchmark processes disable automatic Session Ingest.
Verification
No physical-device or deployed provider/container smoke tests were run. Automated coverage and source comparison validate the extraction; device and deployed consumer checks remain necessary before activating the relevant family.
Visual Changes
N/A — credential handling changes do not add a visual interface.
Reviewer Notes
No new flag needs enabling when this merges. Preserve existing Cloud Agent settings.
NATIVE_RESOURCE_TOKENS_ENABLED,CHAT_RESOURCE_TOKENS_ENABLED,WASTELAND_RESOURCE_TOKENS_ENABLEDfalseBENCHMARK_RESOURCE_TOKENS_ENABLEDfalseEach family also requires Web
SHARED_RESOURCE_TOKENS_ENABLED=true; the master alone does not enable them. Keep native adoption off until physical-device smoke coverage passes. Source-authority checks still apply with issuance off; benchmark ingest is disabled for legacy runs too. Retain compatible readers/runtime support during rollback.Prior validation of the unchanged retained code: 811 mobile tests, 13 shared native contract tests, and 290 benchmark tests passed, with affected typechecks/lint and mobile unused-export checks. Remaining Web typecheck passed after extraction. This extraction changes no remaining application code; full repository or live smoke validation is not claimed.
Explicit resource delegation and its legacy compatibility fix are now #6155. Security Auto Analysis is #6147. Gastown is #6141; Webhook Ingest shipped in #6142. These changes originated in #5857. The remaining PR targets main independently. Cloud Agent Next transport changes are outside this PR.
Consumer audit · Rollout settings.