fix(mobile): hide pull Updating, keep one Live Activity, fix sheet header - #5972
Merged
Conversation
…ader Hide the visible Updating label during Agents pull-to-refresh. Keep the spinner and the screen-reader announcement. Debounce idle Live Activity ends by 5s so brief idle does not start a second card. End extra visible activities when a new card starts. Put the PR form-sheet close caret on the title row. Drop the safe-area top pad.
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (6 files)
Previous Review Summary (commit 84b0c00)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 84b0c00)Status: 1 Issue Found | Recommendation: Address before merge Executive SummaryIdle Live Activity retirement now depends on a 5s JavaScript timer, so a background idle transition can leave the Lock Screen card up for the rest of the ActivityKit lifetime. Overview
Issue Details (click to expand)WARNING
Files Reviewed (13 files)
Reviewed by grok-4.6 · Input: 150.3K · Output: 15.3K · Cached: 510.8K Review guidance: REVIEW.md from base branch |
pandemicsyn
approved these changes
Sep 8, 2026
This was referenced Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Local verification — 2026-09-08
Earlier run; Android verification is completed below. Header fix pushed in
84b0c009b213b537db1a6500ed9b7a1871e79844.pt-3→pt-5).check:unusedwas not run because its command loads a dotenv file, which the local runbook prohibits.Visual changes
The recording shows review opening, keyboard typing, and dismissal. No review, comment, or merge was submitted.
ios-review.mp4
Kilobot finding fixed
276f658a2submits idle dismissal immediately when the app is inactive or backgrounded.iOS lifecycle verification — head
276f658a2Native observations from the real foreground session:
idle-window.mp4
Android verification — head
276f658a2ExpoBattery. OTP sign-in then passed.review-recovered.mp4
comment.mp4
merge.mp4