Skip to content

fix: remove legacy OpenRouter alias handling - #5943

Merged
chrarnoldus merged 3 commits into
mainfrom
respected-windflower
Sep 8, 2026
Merged

fix: remove legacy OpenRouter alias handling#5943
chrarnoldus merged 3 commits into
mainfrom
respected-windflower

Conversation

@chrarnoldus

@chrarnoldus chrarnoldus commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Summary

  • remove the legacy OpenRouter alias allowlist entirely
  • validate model IDs against the Redis-backed OpenRouter catalog only
  • preserve the existing fallback when no model metadata is available

Testing

  • not run (per request; CI will validate)

@chrarnoldus chrarnoldus self-assigned this Sep 7, 2026
@kilo-code-bot

kilo-code-bot Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (1 files)
  • apps/web/src/lib/ai-gateway/providers/gateway-models-cache.test.ts
Previous Review Summaries (2 snapshots, latest commit 4e1b311)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit 4e1b311)

Status: 1 Issue Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 1
SUGGESTION 0
Issue Details (click to expand)

WARNING

File Line Issue
apps/web/src/lib/ai-gateway/providers/gateway-models-cache.ts 117 Removing the remaining OpenRouter alias allowlist leaves gateway-models-cache.test.ts asserting that gpt-4o still bypasses Redis
Files Reviewed (1 files)
  • apps/web/src/lib/ai-gateway/providers/gateway-models-cache.ts - 1 issue

Fix these issues in Kilo Cloud

Previous review (commit 344b292)

Status: 1 Issue Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 1
SUGGESTION 0
Issue Details (click to expand)

WARNING

File Line Issue
apps/web/src/lib/ai-gateway/providers/gateway-models-cache.ts 119 Removing gpt-4o from legacyOpenRouterAliases leaves gateway-models-cache.test.ts asserting that alias still bypasses Redis
Files Reviewed (1 files)
  • apps/web/src/lib/ai-gateway/providers/gateway-models-cache.ts - 1 issue

Fix these issues in Kilo Cloud


Reviewed by grok-4.6 · Input: 57.7K · Output: 4.6K · Cached: 160.9K

Review guidance: REVIEW.md from base branch main

@chrarnoldus chrarnoldus changed the title fix: remove stale OpenRouter aliases fix: remove legacy OpenRouter alias handling Sep 7, 2026
@chrarnoldus

Copy link
Copy Markdown
Contributor Author

Fixed in 7988fd3 by removing the obsolete test that asserted legacy aliases bypass Redis. The remaining tests cover Redis catalog acceptance, rejection, and the empty-catalog fallback.

@chrarnoldus
chrarnoldus merged commit 8bc5aa6 into main Sep 8, 2026
17 checks passed
@chrarnoldus
chrarnoldus deleted the respected-windflower branch September 8, 2026 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants