Repository navigation
feat(cloud-agent): send saved diff reviews to chats - #5817
Conversation
987fa7c to
14b8fdb
Compare
b22f8fa to
a71610f
Compare
a71610f to
4cf9d58
Compare
4cf9d58 to
2c2abda
Compare
2c2abda to
10eaade
Compare
10eaade to
3dd0a0e
Compare
3dd0a0e to
7cac306
Compare
7cac306 to
8467a86
Compare
8467a86 to
6f4a8c9
Compare
fcfc693 to
30bc04e
Compare
30bc04e to
26658b4
Compare
26658b4 to
9a0611a
Compare
9a0611a to
97ac3a6
Compare
11e3830 to
cce3370
Compare
cce3370 to
30c4b5f
Compare
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryThe branch was restacked onto base Files Reviewed (0 changed files this pass)The only differences inside the PR file list between
All other 38 PR files are byte-identical to the previously reviewed revision. Prior findings were verified resolved or retracted at earlier revisions and none is carried forward; the retained-comment fix ( Previous Review Summaries (12 snapshots, latest commit 48a59a4)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 48a59a4)Status: No Issues Found | Recommendation: Merge Executive SummaryThe retained-comment fix resolves the previous suggestion: the review dialog now labels comments kept on older captures and offers a per-comment discard path, and no new defects were found in the changed code. Files Reviewed (2 files)
Previous review (commit 22e404d)Status: 1 Issues Found | Recommendation: Address before merge Executive SummaryThe incremental commit ( Overview
Issue Details (click to expand)SUGGESTION
Files Reviewed (5 files, incremental 14ae058..22e404d)
Only the incremental commit's changed files were re-analyzed; findings in files untouched by this increment were not carried forward. Fix these issues in Kilo Cloud Previous review (commit 14ae058)Status: No Issues Found | Recommendation: Merge Executive SummaryThe PR branch was restacked onto its base ( Files Reviewed (0 files this pass)The PR diff ( Prior findings re-verified against current code (all PR files are byte-identical to the last reviewed revision):
Previous review (commit 1e53b36)Status: No Issues Found | Recommendation: Merge Executive SummaryThe PR branch was restacked onto the latest base (the previously reviewed commit is no longer an ancestor of HEAD), but the PR's own changed files are byte-identical to the last reviewed revision, so there are no newly changed lines. All prior findings are verified resolved or correctly retracted at HEAD Files Reviewed (0 changed files this pass)The PR diff (
Previous review (commit 6536096)Status: No Issues Found | Recommendation: Merge Executive SummaryThe incremental diff since the last reviewed commit is empty (identical tree hash), so no newly changed lines required review, and both previously reported issues are verified fixed at HEAD: Files Reviewed (0 changed files this pass)The incremental diff from
Previous review (commit defd273)Status: No Issues Found | Recommendation: Merge Executive SummaryThe incremental commits resolve both prior findings: Files Reviewed (4 files)
Previous review (commit b2edcd1)Status: 2 Issues Found | Recommendation: Address before merge Fix these issues in Kilo Cloud Executive SummaryThe new Overview
Issue Details (click to expand)WARNING
SUGGESTION
Files Reviewed (24 source files plus changed test suites)
Previous review (commit d7b80a3)Status: 1 Issue Found | Recommendation: Address before merge Fix these issues in Kilo Cloud Overview
Issue Details (click to expand)WARNING
Files Reviewed (6 files)
Previous review (commit ce81aaf)Status: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Previous review (commit 23a0bc6)Status: 1 Issue Found | Recommendation: Address before merge Fix these issues in Kilo Cloud Executive SummaryA generation-mismatch IndexedDB clear can delete a newer in-progress review draft after accept or discard. Overview
Issue Details (click to expand)WARNING
Files Reviewed (2 files)
Previous review (commit 4671023)Status: 1 Issue Found | Recommendation: Address before merge Fix these issues in Kilo Cloud Executive SummaryA generation-mismatch IndexedDB clear can delete a newer in-progress review draft after accept or discard. Overview
Issue Details (click to expand)WARNING
Files Reviewed (8 files)
Previous review (commit 82fa7e4)Status: 4 Issues Found | Recommendation: Address before merge Fix these issues in Kilo Cloud Overview
Issue Details (click to expand)WARNING
Files Reviewed (40 files)
Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
d7b80a3 to
8186e5a
Compare
defd273 to
6536096
Compare
6536096 to
1e53b36
Compare
1e53b36 to
14ae058
Compare
- Add saved-diff line/range comments, cross-file drafts, and one batched Send review to agent action. - Preserve immutable reviewed context and explicit stale-review handling across file and chat switches. - Pin and authorize the destination worktree/chat, retaining the same message identity for uncertain retries. Restacked onto latest main and squashed to one commit.
Do not drop a saved comment when its diff is missing and do not clear editor text when it cannot be rebased. Show the retained editors in the review dialog and add regression coverage for missing diffs, moved quotes and unrebasable editors.
The review dialog now shows each comment's capture freshness and offers a discard action for comments that are not on the current saved capture, so a retained comment can be identified and removed before sending.
48a59a4 to
6d8ea4c
Compare
2 participants
Summary
Verification
No manual browser or live-provider tests were rerun during this restack. Existing pending work was preserved in named stash/backup refs; local handoff and evidence files remain unchanged and excluded.
Visual Changes
Reviewer Notes
Stacked on #5816 (eshurakov/boundless-sphinx). Three commits, including GitHub-style review UX. The merge preserves both commit-card and review wiring, plus upstream autoCommit: true and expected-worktree authorization checks.
Final combined verification passed: web lint, full web typecheck with tRPC declaration build, and eight setup-free Jest suites / 241 tests, including the native review wrappers. All 29 terminal-navigation tests pass after adding the missing review-boundary mocks to their existing fixture; this correction changes no product behavior. The standalone native review suites (77 tests) and review-send/client suites (131 tests) also passed earlier. Formatting, whitespace, and independent merge review passed. No database setup or browser evidence is implied by these isolated tests.