Skip to content

fix(mobile): use current Lucide icon paths - #5654

Merged
iscekic merged 1 commit into
mainfrom
fix/mobile-eas-release-33173634592
Aug 28, 2026
Merged

fix(mobile): use current Lucide icon paths#5654
iscekic merged 1 commit into
mainfrom
fix/mobile-eas-release-33173634592

Conversation

@iscekic

@iscekic iscekic commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Fix the JavaScript bundling failure in release run 33173634592.
  • Replace the obsolete history and smile-plus subpaths with their canonical Lucide paths. Preserve the existing local exports.
  • Add a regression test for every icon runtime path. Allow Node imports only in that test.

Verification

  • Ran the failed bundling phase locally for Android: CI=true SENTRY_DISABLE_AUTO_UPLOAD=true pnpm exec expo export:embed --eager --platform android --dev false.
  • Ran the failed bundling phase locally for iOS: CI=true SENTRY_DISABLE_AUTO_UPLOAD=true pnpm exec expo export:embed --eager --platform ios --dev false.
  • Both local bundles passed with the committed environment defaults. I did not run signed native builds or store submissions.
  • No device tests: this fix selects the same icons through their supported module paths.

Visual Changes

N/A

Reviewer Notes

  • Lucide 1.33.0 retains declarations for both aliases but omits their runtime files. Typecheck alone does not detect this failure.
  • The regression test failed on both old paths before the fix and passed afterward.
  • Automated checks passed: 6,497 mobile tests, mobile typecheck, lint, unused-code checks, formatting, and git diff --check.
  • An independent review found no remaining issues.

@iscekic iscekic self-assigned this Aug 28, 2026
@kilo-code-bot

kilo-code-bot Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (3 files)
  • apps/mobile/.oxlintrc.json
  • apps/mobile/src/components/ui/icons.test.ts
  • apps/mobile/src/components/ui/icons.ts

Reviewed by grok-4.6 · Input: 39.6K · Output: 8.6K · Cached: 210.7K

Review guidance: REVIEW.md from base branch main

@iscekic
iscekic enabled auto-merge (squash) August 28, 2026 14:44
@iscekic
iscekic merged commit bb6ae21 into main Aug 28, 2026
23 checks passed
@iscekic
iscekic deleted the fix/mobile-eas-release-33173634592 branch August 28, 2026 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants