Skip to content

(janitor/test-prune): consolidate redundant mock-echo tests in admin-github-router #5634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pandemicsyn merged 1 commit into from
Aug 28, 2026
Merged

(janitor/test-prune): consolidate redundant mock-echo tests in admin-github-router #5634

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 6 additions & 58 deletions apps/web/src/routers/admin-github-router.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,37 +68,7 @@ describe('admin.github.getKilocodeOpenPullRequestsSummary', () => {
);
});

it('returns summary for admin users', async () => {
const mockSummary = {
totalOpenPullRequests: 10,
teamOpenPullRequests: 4,
externalOpenPullRequests: 6,
externalOpenPullRequestsList: [
{
number: 123,
title: 'Fix thing',
url: 'https://github.com/Kilo-Org/kilocode/pull/123',
repo: 'kilocode',
authorLogin: 'external-user',
createdAt: new Date('2020-01-01T00:00:00.000Z').toISOString(),
ageDays: 12,
commentCount: 3,
teamCommented: true,
reviewStatus: 'commented',
},
],
updatedAt: new Date('2020-01-01T00:00:00.000Z').toISOString(),
};

(getKilocodeRepoOpenPullRequestsSummary as jest.Mock).mockResolvedValue(mockSummary);

const caller = await createCallerForUser(adminUser.id);
const result = await caller.admin.github.getKilocodeOpenPullRequestsSummary();

expect(result).toEqual(mockSummary);
});

it('passes repos parameter through to the service', async () => {
it('returns the service response and passes repos/includeDrafts through to the service', async () => {
const mockSummary = {
totalOpenPullRequests: 1,
teamOpenPullRequests: 0,
Expand All @@ -110,11 +80,12 @@ describe('admin.github.getKilocodeOpenPullRequestsSummary', () => {
(getKilocodeRepoOpenPullRequestsSummary as jest.Mock).mockResolvedValue(mockSummary);

const caller = await createCallerForUser(adminUser.id);
await caller.admin.github.getKilocodeOpenPullRequestsSummary({
const result = await caller.admin.github.getKilocodeOpenPullRequestsSummary({
repos: ['kilocode', 'cloud'],
includeDrafts: true,
});

expect(result).toEqual(mockSummary);
expect(getKilocodeRepoOpenPullRequestsSummary).toHaveBeenCalledWith(
expect.objectContaining({
repos: ['kilocode', 'cloud'],
Expand Down Expand Up @@ -157,8 +128,6 @@ describe('admin.github.getKilocodeRecentlyMergedExternalPRs', () => {
const result = await caller.admin.github.getKilocodeRecentlyMergedExternalPRs();

expect(result).toEqual(mockMergedPrs);
expect(result.length).toBe(2);
expect(result[0]?.number).toBe(456);
});
});

Expand All @@ -171,7 +140,7 @@ describe('admin.github.getKilocodeRecentlyClosedExternalPRs', () => {
);
});

it('returns recently closed external PRs for admin users', async () => {
it('returns the service response and passes repos parameter through to the service', async () => {
const mockClosedPrs = {
prs: [
{
Expand Down Expand Up @@ -206,32 +175,11 @@ describe('admin.github.getKilocodeRecentlyClosedExternalPRs', () => {
(getKilocodeRepoRecentlyClosedExternalPRs as jest.Mock).mockResolvedValue(mockClosedPrs);

const caller = await createCallerForUser(adminUser.id);
const result = await caller.admin.github.getKilocodeRecentlyClosedExternalPRs();

expect(result).toEqual(mockClosedPrs);
expect(result.prs.length).toBe(2);
expect(result.prs[0]?.status).toBe('merged');
expect(result.prs[1]?.status).toBe('closed');
expect(typeof result.thisWeekMergedCount).toBe('number');
expect(typeof result.thisWeekClosedCount).toBe('number');
expect(typeof result.weekStart).toBe('string');
});

it('passes repos parameter through to the service', async () => {
const mockClosedPrs = {
prs: [],
thisWeekMergedCount: 0,
thisWeekClosedCount: 0,
weekStart: new Date('2024-01-15T00:00:00.000Z').toISOString(),
};

(getKilocodeRepoRecentlyClosedExternalPRs as jest.Mock).mockResolvedValue(mockClosedPrs);

const caller = await createCallerForUser(adminUser.id);
await caller.admin.github.getKilocodeRecentlyClosedExternalPRs({
const result = await caller.admin.github.getKilocodeRecentlyClosedExternalPRs({
repos: ['cloud'],
});

expect(result).toEqual(mockClosedPrs);
expect(getKilocodeRepoRecentlyClosedExternalPRs).toHaveBeenCalledWith(
expect.objectContaining({
repos: ['cloud'],
Expand Down