Skip to content

(janitor/test-prune): Remove tautological/duplicate tests in utils.test.ts #5492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pandemicsyn merged 1 commit into from
Aug 25, 2026
Merged

(janitor/test-prune): Remove tautological/duplicate tests in utils.test.ts #5492

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 0 additions & 30 deletions apps/web/src/lib/utils.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,20 +25,6 @@ describe('assertNotNull', () => {
expect(() => assertNotNullish(null, customMessage)).toThrow(customMessage);
expect(() => assertNotNullish(undefined, customMessage)).toThrow(customMessage);
});

it('should properly narrow types (compile-time test)', () => {
// This test verifies TypeScript type narrowing works correctly
const nullableString: string | null = 'test';
const nullableNumber: number | undefined = 42;

// After assertNotNull, TypeScript should know these are not null/undefined
assertNotNullish(nullableString);
assertNotNullish(nullableNumber);

// These should work without type errors after assertion
expect(nullableString.toUpperCase()).toBe('TEST');
expect(nullableNumber.toFixed(2)).toBe('42.00');
});
});

describe('parseResultJsonWithZodSchema', () => {
Expand Down Expand Up @@ -168,14 +154,6 @@ describe('parseResultJsonWithZodSchema', () => {
expect(result).toEqual(arrayData);
expect(jsonMock).toHaveBeenCalledTimes(1);
});

it('should preserve console.log behavior on JSON parse error', async () => {
const { response } = createMockResponse(400, 'Bad Request', null, true);

await expect(parseResultJsonWithZodSchema(response, testSchema)).rejects.toThrow(
'Failed to fetch data: Bad Request'
);
});
});

describe('isDateOnlyString', () => {
Expand Down Expand Up @@ -283,12 +261,4 @@ describe('requireNotNull', () => {
expect(() => toNonNullish(null, 'FOO')).toThrow('FOO');
expect(() => toNonNullish(undefined, 'FOO')).toThrow('FOO');
});

it('should properly narrow return type (compile-time test)', () => {
const nullableString: string | null = 'test';
const nullableNumber: number | undefined = 42;

expect(toNonNullish(nullableString).toUpperCase()).toBe('TEST');
expect(toNonNullish(nullableNumber).toFixed(2)).toBe('42.00');
});
});