Skip to content

fix(gdpr): use connect.sid for Substack credentials - #5446

Merged
eshurakov merged 1 commit into
mainfrom
eshurakov/crimson-vista
Aug 24, 2026
Merged

fix(gdpr): use connect.sid for Substack credentials#5446
eshurakov merged 1 commit into
mainfrom
eshurakov/crimson-vista

Conversation

@eshurakov

Copy link
Copy Markdown
Contributor

Summary

  • use the Substack connect.sid cookie when normalizing stored credentials
  • default the publication URL to https://blog.kilo.ai and share that behavior with the deletion handler
  • update admin guidance, environment documentation, and focused tests

Verification

  • oxfmt --list-different passed
  • type-aware oxlint passed with 0 warnings and 0 errors
  • git diff --check passed
  • targeted Jest could not start because this worktree has no installed dependencies and the external Jest setup is missing ts-node

@kilo-code-bot

kilo-code-bot Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Executive Summary

Re-reviewed the rewritten connect.sid credential and default publication-URL changes with high confidence; no correctness, security, or runtime issues on changed lines.

Files Reviewed (3 files)
  • apps/web/src/app/admin/deletion-queue/DeletionQueueContent.tsx
  • apps/web/src/lib/user/deletion-queue/deletion-substack-credential.test.ts
  • apps/web/src/lib/user/deletion-queue/deletion-substack-credential.ts
Previous Review Summary (commit 200540c)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit 200540c)

Status: No Issues Found | Recommendation: Merge

Executive Summary

Reviewed the Substack connect.sid credential and default publication-URL changes with high confidence; no correctness, security, or runtime issues on changed lines.

Files Reviewed (6 files)
  • ENVIRONMENT.md
  • apps/web/src/app/admin/deletion-queue/DeletionQueueContent.tsx
  • apps/web/src/lib/user/deletion-queue/deletion-constants.ts
  • apps/web/src/lib/user/deletion-queue/deletion-substack-credential.test.ts
  • apps/web/src/lib/user/deletion-queue/deletion-substack-credential.ts
  • apps/web/src/lib/user/deletion-queue/handlers/substack.ts

Reviewed by grok-4.6 · Input: 53K · Output: 6.1K · Cached: 339.5K

Review guidance: REVIEW.md from base branch main

@eshurakov
eshurakov force-pushed the eshurakov/crimson-vista branch from 200540c to f97de3f Compare August 24, 2026 10:14

@pandemicsyn pandemicsyn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bot flagged one, but i think as long as theres no deletions in flight when this rolls out its kind of a non issue.

return null;
}
return trimmed.includes('=') ? trimmed : `substack.sid=${trimmed}`;
return trimmed.includes('=') ? trimmed : `connect.sid=${trimmed}`;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bot: Legacy stored substack.sid cookies are not migrated to connect.sid.

Suggested fix: Recognize and rewrite the legacy cookie name in raw cookie material before returning it (including when it appears in a multi-cookie header), then add a regression test for substack.sid=.... Add or update a handler-level test that stores the legacy value and asserts the outbound deletion request sends connect.sid=.... This is needed because the deletion handler calls this normalizer for persisted credentials, while its existing test setup still stores substack.sid=test-cookie.

@eshurakov
eshurakov merged commit 58ce33d into main Aug 24, 2026
13 checks passed
@eshurakov
eshurakov deleted the eshurakov/crimson-vista branch August 24, 2026 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants