-
Notifications
You must be signed in to change notification settings - Fork 8
feat(mobile): enrich Sentry error context #5432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -43,8 +43,15 @@ export async function stripImageMetadata( | |
| format: saveFormatFor(extension), | ||
| }); | ||
| return result.uri; | ||
| } catch (error) { | ||
| Sentry.captureException(error); | ||
| } catch { | ||
| Sentry.captureException(new Error('Attachment image metadata strip failed'), { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. bot: Preserve the original image-processing failure when reporting it Suggested fix: Bind the caught value and report that exception with the new static tags/fingerprint (for example, |
||
| tags: { | ||
| 'error.subsystem': 'agent-attachments', | ||
| 'error.operation': 'strip-image-metadata', | ||
| }, | ||
| extra: { outputExtension: strippedExtension(extension) }, | ||
| fingerprint: ['agent-attachments-strip-image-metadata'], | ||
| }); | ||
| return uri; | ||
| } | ||
| } | ||
Uh oh!
There was an error while loading. Please reload this page.