feat(pr-review): open formSheets full-height with roomier density - #5402
Merged
Conversation
Add sheetInitialDetentIndex 'last' so Merge, Submit review, comment composer, and file-navigator open at the full detent. Roomier shared footer, body spacing, chips, inputs, and labels match native iOS form-sheet density.
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (1 files)
Previous Review Summary (commit c0a0e57)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit c0a0e57)Status: No Issues Found | Recommendation: Merge Files Reviewed (7 files)
Reviewed by grok-4.6 · Input: 87.8K · Output: 5.1K · Cached: 112K Review guidance: REVIEW.md from base branch |
PrFormSheetFooter no longer has any caller passing className, so remove the prop and the cn merge.
pandemicsyn
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When you open the merge, submit review, comment composer, or file navigator sheet, it now fills the screen height. You can still pull a sheet down to its half-height position.
The merge, submit review, and comment composer sheets now use larger buttons, chips, labels, and input fields, with more spacing around each field.
The four PR-review form sheets open at the full detent instead of the half detent. The shared sheet options set
sheetInitialDetentIndextolast, so the half detent remains only as a drag-down target. No route, parameter, or stored format changes.Files
apps/mobile/src/app/(app)/pr-review/[owner]/[repo]/[number]/_layout.tsx— addssheetInitialDetentIndex: 'last'to the sharedsheetOptionsused by the comment composer, review submit, merge, and file navigator screens.The merge, submit review, and comment composer sheets adopt native iOS form-sheet density. Labels and chips move from
text-xstotext-sm, chips and inputs grow, and body containers usegap-4 px-6 pt-4. The shared footer drops itsclassNameoverride prop and defaults topx-6 pb-4 pt-3; the merge and composer footers drop their tight overrides and small buttons, and every Cancel button usesmt-2.Files
apps/mobile/src/components/pr-review/pr-form-sheet-chrome.tsx— removes the unusedcnimport and the footerclassNameprop; changes the default footer padding frompb-1.5 pt-1topb-4 pt-3.apps/mobile/src/components/pr-review/merge/pr-merge-sheet-parts.tsx— grows method chips, the title input, commit message heights, the delete-branch row, and the body gap; dropssize="sm"and the tight footer override; Cancel usesmt-2.apps/mobile/src/components/pr-review/pr-review-comment-composer-parts.tsx— drops the tight footer override andsize="sm"buttons; grows the context preview; setsmt-2on the secondary and Cancel buttons.apps/mobile/src/components/pr-review/pr-review-comment-composer.tsx— grows the body container togap-4 px-6 pt-4and the Comment label totext-sm.apps/mobile/src/components/pr-review/pr-review-submit.tsx— grows the body container togap-4 px-6 pt-4and the Cancel spacing tomt-2.apps/mobile/src/components/pr-review/review-event-chips.tsx— grows the review event chips tomin-h-11 px-4 py-2 text-smand the row gap togap-2.Tests: none changed.
Generated: none changed.
Verification
On iOS, 2 cases ran and both passed.
No defects were found.
Visual Changes
Merge sheet — A user now sees the merge sheet open at the full detent with METHOD chips, Commit title, and Commit message visible.
With the keyboard open, the Cancel button stays visible after the Commit title gains focus.
Submit review sheet — A user now sees the submit review sheet open at the full detent with REVIEW EVENT chips, Comment, and Review summary visible.
Reviewer Notes
Human steps: none needed.
Notes: none.