Skip to content

Expose sub-organizations before initial setup - #5381

Merged
jrf0110 merged 2 commits into
mainfrom
feature/show-sub-organizations-experience
Aug 20, 2026
Merged

Expose sub-organizations before initial setup#5381
jrf0110 merged 2 commits into
mainfrom
feature/show-sub-organizations-experience

Conversation

@jrf0110

@jrf0110 jrf0110 commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Summary

  • show the Sub-organizations navigation and dashboard card before an organization has children
  • allow eligible parent organizations with zero children to open the management experience
  • add setup-oriented empty states and regression coverage

Verification

  • pnpm --filter web exec jest --runInBand --runTestsByPath <two changed test paths>
  • pnpm --filter web typecheck
  • pnpm --filter web lint
  • git diff --check origin/main...HEAD
  • pnpm vercel --version (59.0.0)

Comment thread apps/web/src/app/(app)/components/OrganizationAppSidebar.tsx Outdated
@kilo-code-bot

kilo-code-bot Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (2 files)
  • apps/web/src/app/(app)/components/OrganizationAppSidebar.tsx
  • apps/web/src/components/organizations/OrganizationDashboard.tsx
Previous Review Summary (commit 394b344)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit 394b344)

Status: 2 Issues Found | Recommendation: Address before merge

Executive Summary

Removing the children-length gate also exposes the sub-organizations nav and dashboard setup card on child organizations, which cannot nest and are redirected away from the management page.

Overview

Severity Count
CRITICAL 0
WARNING 2
SUGGESTION 0
Issue Details (click to expand)

WARNING

File Line Issue
apps/web/src/app/(app)/components/OrganizationAppSidebar.tsx 130 Sub-organizations nav now appears on child organizations
apps/web/src/components/organizations/OrganizationChildOrganizationsCard.tsx 115 Setup card is shown for child organizations
Files Reviewed (6 files)
  • apps/web/src/app/(app)/components/OrganizationAppSidebar.tsx - 1 issue
  • apps/web/src/app/(app)/organizations/[id]/sub-organizations/SubOrganizationSections.tsx - 0 issues
  • apps/web/src/app/(app)/organizations/[id]/sub-organizations/layout.test.ts - 0 issues
  • apps/web/src/app/(app)/organizations/[id]/sub-organizations/layout.tsx - 0 issues
  • apps/web/src/components/organizations/OrganizationChildOrganizationsCard.test.ts - 0 issues
  • apps/web/src/components/organizations/OrganizationChildOrganizationsCard.tsx - 1 issue

Fix these issues in Kilo Cloud


Reviewed by grok-4.6 · Input: 172.3K · Output: 7.9K · Cached: 194.9K

Review guidance: REVIEW.md from base branch main

@jrf0110
jrf0110 force-pushed the feature/show-sub-organizations-experience branch from 394b344 to 4c6e29e Compare August 19, 2026 18:09
@jrf0110

jrf0110 commented Aug 19, 2026

Copy link
Copy Markdown
Contributor Author

Addressed both review findings in 38a7117: the Sub-organizations sidebar item and dashboard setup card now explicitly require a root organization (parent_organization_id === null). This keeps the zero-child setup experience available to eligible roots without exposing dead-end UI on child organizations.

@jrf0110
jrf0110 merged commit 4825d0a into main Aug 20, 2026
13 checks passed
@jrf0110
jrf0110 deleted the feature/show-sub-organizations-experience branch August 20, 2026 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants