fix(ai-gateway): preserve Gemini thought signatures - #5377
Merged
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Previous Review Summary (commit 87774b5)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 87774b5)Status: 4 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)CRITICAL
WARNING
Files Reviewed (13 files)
Reviewed by grok-4.6 · Input: 97.3K · Output: 13.2K · Cached: 195.2K Review guidance: REVIEW.md from base branch |
marius-kilocode
approved these changes
Aug 20, 2026
johnnyeric
approved these changes
Aug 20, 2026
chrarnoldus
enabled auto-merge (squash)
August 20, 2026 08:55
chrarnoldus
disabled auto-merge
August 20, 2026 08:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reasoning_detailsgoogle-gemini-v1encrypted details to nativethought_signaturefields on follow-up requestsVerification
pnpm --filter web exec jest --runInBand --forceExit --runTestsByPath src/lib/ai-gateway/rewriteModelResponse.test.ts src/lib/ai-gateway/experiments/build-direct-provider.test.ts src/lib/ai-gateway/providers/apply-provider-specific-logic.test.ts src/lib/ai-gateway/providers/provider-definitions.test.ts 'src/app/api/openrouter/[...path]/route.test.ts'(180 tests passed)pnpm --filter web typecheckpnpm --filter web lintgit diff --check