Skip to content

fix(ai-gateway): align reasoning provider settings - #5372

Merged
chrarnoldus merged 3 commits into
mainfrom
fix/ai-gateway-reasoning-settings
Aug 19, 2026
Merged

fix(ai-gateway): align reasoning provider settings#5372
chrarnoldus merged 3 commits into
mainfrom
fix/ai-gateway-reasoning-settings

Conversation

@chrarnoldus

Copy link
Copy Markdown
Contributor

Summary

  • route ByteDance, Friendli GLM, and Perplexity Kimi through their tested Chat Completions APIs
  • map Friendli reasoning controls to its thinking template flags and keep Kimi K3 reasoning mandatory
  • remove stale MiniMax and custom-provider compatibility settings

Testing

  • pnpm --filter web exec jest --runInBand src/lib/ai-gateway/providers/model-settings.test.ts src/lib/ai-gateway/providers/provider-definitions.test.ts src/lib/ai-gateway/providers/variants.test.ts src/lib/ai-gateway/providers/partner-routing.test.ts src/lib/ai-gateway/providers/direct-byok/opencode-go.test.ts src/lib/ai-gateway/models.test.ts
  • pnpm --filter web typecheck
  • scripts/typecheck-all.sh --changes-only
  • pnpm --filter web lint
  • pnpm --filter @kilocode/db lint
  • changed-file formatting and git diff --check

@chrarnoldus chrarnoldus self-assigned this Aug 19, 2026
Comment thread apps/web/src/lib/ai-gateway/providers/model-settings.ts
@kilo-code-bot

kilo-code-bot Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: 1 Issue Found | Recommendation: Address before merge

Executive Summary

The Kimi none-variant exception still compares the raw model ID, so suffixed IDs like moonshotai/kimi-k3:free still get a non-reasoning variant.

Overview

Severity Count
CRITICAL 0
WARNING 1
SUGGESTION 0
Issue Details (click to expand)

WARNING

File Line Issue
apps/web/src/lib/ai-gateway/providers/model-settings.ts 50 Kimi none-variant exception misses suffixed model IDs
Files Reviewed (1 files)
  • apps/web/src/lib/ai-gateway/model-api-kinds.test.ts - 0 issues

Fix these issues in Kilo Cloud

Previous Review Summaries (2 snapshots, latest commit d8a4a38)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit d8a4a38)

Status: 1 Issue Found | Recommendation: Address before merge

Executive Summary

The Kimi none-variant exception still compares the raw model ID, so suffixed IDs like moonshotai/kimi-k3:free still get a non-reasoning variant.

Overview

Severity Count
CRITICAL 0
WARNING 1
SUGGESTION 0
Issue Details (click to expand)

WARNING

File Line Issue
apps/web/src/lib/ai-gateway/providers/model-settings.ts 50 Kimi none-variant exception misses suffixed model IDs
Files Reviewed (1 files)
  • apps/web/src/lib/ai-gateway/providers/provider-definitions.ts - 0 issues

Fix these issues in Kilo Cloud

Previous review (commit 5e99861)

Status: 1 Issue Found | Recommendation: Address before merge

Executive Summary

The Kimi none-variant exception compares the raw model ID, so suffixed IDs like moonshotai/kimi-k3:free still get a non-reasoning variant.

Overview

Severity Count
CRITICAL 0
WARNING 1
SUGGESTION 0
Issue Details (click to expand)

WARNING

File Line Issue
apps/web/src/lib/ai-gateway/providers/model-settings.ts 50 Kimi none-variant exception misses suffixed model IDs
Files Reviewed (10 files)
  • apps/web/src/lib/ai-gateway/providers/direct-byok/opencode-go.test.ts - 0 issues
  • apps/web/src/lib/ai-gateway/providers/model-settings.test.ts - 0 issues
  • apps/web/src/lib/ai-gateway/providers/model-settings.ts - 1 issue
  • apps/web/src/lib/ai-gateway/providers/openrouter/types.ts - 0 issues
  • apps/web/src/lib/ai-gateway/providers/partner-routing.test.ts - 0 issues
  • apps/web/src/lib/ai-gateway/providers/provider-definitions.test.ts - 0 issues
  • apps/web/src/lib/ai-gateway/providers/provider-definitions.ts - 0 issues
  • apps/web/src/lib/ai-gateway/providers/variants.test.ts - 0 issues
  • apps/web/src/lib/ai-gateway/providers/variants.ts - 0 issues
  • packages/db/src/schema-types.ts - 0 issues

Fix these issues in Kilo Cloud


Reviewed by grok-4.6 · Input: 82.8K · Output: 7.9K · Cached: 208.5K

Review guidance: REVIEW.md from base branch main

Co-authored-by: kiloconnect[bot] <240665456+kiloconnect[bot]@users.noreply.github.com>
@chrarnoldus
chrarnoldus merged commit 0149fad into main Aug 19, 2026
43 checks passed
@chrarnoldus
chrarnoldus deleted the fix/ai-gateway-reasoning-settings branch August 19, 2026 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants