Skip to content

fix(web-env): show masked secret input - #5367

Merged
RSO merged 1 commit into
mainfrom
webenv-set-password-mask
Aug 19, 2026
Merged

fix(web-env): show masked secret input#5367
RSO merged 1 commit into
mainfrom
webenv-set-password-mask

Conversation

@RSO

@RSO RSO commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Summary

CleanShot 2026-08-19 at 11 16 27@2x
  • display one * for each character entered or pasted into pnpm web:env set secret prompts
  • remove the corresponding mask when Backspace removes a character
  • keep the plaintext secret hidden

@kilo-code-bot

kilo-code-bot Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Executive Summary

Reviewed the readSecret mask/backspace change in scripts/web-env/shared.ts; the visual * / \b \b updates match the stored value and introduce no correctness or leak issues.

Files Reviewed (1 files)
  • scripts/web-env/shared.ts

Reviewed by grok-4.6 · Input: 70K · Output: 6.4K · Cached: 131.1K

Review guidance: REVIEW.md from base branch main

@RSO
RSO enabled auto-merge (squash) August 19, 2026 09:18
@RSO
RSO merged commit c73e35a into main Aug 19, 2026
13 checks passed
@RSO
RSO deleted the webenv-set-password-mask branch August 19, 2026 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants