Skip to content

fix(data-exports): redirect guests to sign in #5352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pandemicsyn merged 1 commit into from
Aug 18, 2026
Merged

fix(data-exports): redirect guests to sign in #5352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 14 additions & 12 deletions apps/web/src/app/(app)/data-exports/page.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,12 @@
import React from 'react';

const mockGetUserFromAuth = jest.fn();
const mockNotFound = jest.fn(() => {
throw new Error('NEXT_NOT_FOUND');
});
const mockGetUserFromAuthOrRedirect = jest.fn();

(globalThis as typeof globalThis & { React: typeof React }).React = React;

jest.mock('@/lib/user/server', () => ({ getUserFromAuth: mockGetUserFromAuth }));
jest.mock('next/navigation', () => ({ notFound: mockNotFound }));
jest.mock('@/lib/user/server', () => ({
getUserFromAuthOrRedirect: mockGetUserFromAuthOrRedirect,
}));
jest.mock('@/components/PageLayout', () => ({ PageLayout: () => null }));
jest.mock('./DataExportsClient', () => ({ DataExportsClient: () => null }));
jest.mock('./RequestDataDeletionCard', () => ({ RequestDataDeletionCard: () => null }));
Expand All @@ -18,19 +16,23 @@ describe('DataExportsPage', () => {
jest.clearAllMocks();
});

it('authenticates the visitor without requiring Kilo staff', async () => {
mockGetUserFromAuth.mockResolvedValue({ user: null });
it('redirects unauthenticated visitors to sign in and returns them to data exports', async () => {
mockGetUserFromAuthOrRedirect.mockRejectedValue(new Error('NEXT_REDIRECT'));
const { default: DataExportsPage } = await import('./page');

await expect(DataExportsPage()).rejects.toThrow('NEXT_NOT_FOUND');
expect(mockGetUserFromAuth).toHaveBeenCalledWith({ adminOnly: false });
await expect(DataExportsPage()).rejects.toThrow('NEXT_REDIRECT');
expect(mockGetUserFromAuthOrRedirect).toHaveBeenCalledWith(
'/users/sign_in?callbackPath=/data-exports'
);
});

it('renders for a signed-in non-admin user', async () => {
mockGetUserFromAuth.mockResolvedValue({ user: { id: 'user-1', is_admin: false } });
mockGetUserFromAuthOrRedirect.mockResolvedValue({ id: 'user-1', is_admin: false });
const { default: DataExportsPage } = await import('./page');

await expect(DataExportsPage()).resolves.toBeTruthy();
expect(mockNotFound).not.toHaveBeenCalled();
expect(mockGetUserFromAuthOrRedirect).toHaveBeenCalledWith(
'/users/sign_in?callbackPath=/data-exports'
);
});
});
6 changes: 2 additions & 4 deletions apps/web/src/app/(app)/data-exports/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,10 @@
import { getUserFromAuth } from '@/lib/user/server';
import { notFound } from 'next/navigation';
import { getUserFromAuthOrRedirect } from '@/lib/user/server';
import { PageLayout } from '@/components/PageLayout';
import { DataExportsClient } from './DataExportsClient';
import { RequestDataDeletionCard } from './RequestDataDeletionCard';

export default async function DataExportsPage() {
const { user } = await getUserFromAuth({ adminOnly: false });
if (!user) notFound();
await getUserFromAuthOrRedirect('/users/sign_in?callbackPath=/data-exports');

return (
<PageLayout
Expand Down