fix(data-export): handle bigint hourly cursors - #5350
Merged
Conversation
St0rmz1
approved these changes
Aug 18, 2026
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryReviewed the hourly bigint cursor/country-id normalization and matching tests; the mapper now accepts the shared INT8 parser’s Files Reviewed (2 files)
Reviewed by grok-4.6 · Input: 70.8K · Output: 11.5K · Cached: 377.2K Review guidance: REVIEW.md from base branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
string,number, orbigintwhen exportingmicrodollar_usage_hourly.INT8parser returning both a real country ID and the null sentinel as JavaScriptbigintvalues.Verification
-1null sentinels.Visual Changes
N/A
Reviewer Notes
numberandstring, but@kilocode/db/clientglobally parses PostgreSQLINT8as JavaScriptbigint. This caused every observed hourly source read to fail after a successful database query.ORDER BY COALESCE(vercel_ip_country_id, -1)continues to match the warehouse expression indexes.