feat(cloud-agent-next): authenticate git via a credential helper - #5336
Conversation
edc789c to
7fe8224
Compare
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryPer-session git-credentials file plus helper precedence fixes the stale process GH_TOKEN clone path; managed and generic remotes stay canonical. Files Reviewed (4 files)
Previous Review Summaries (2 snapshots, latest commit 6265c94)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 6265c94)Status: No Issues Found | Recommendation: Merge Executive SummaryCredential-helper clone wiring on the worker and wrapper is consistent: managed remotes stay credential-free, leftover type:git + platform:github PATs now populate GH_TOKEN, and prior review findings are fixed. Files Reviewed (6 files)
Previous reviewCouncil ReviewAdvisory review — findings reported, no merge decision Specialist votes: 0 block, 4 pass. Advisory mode records these votes but does not aggregate them into a decision.
Findings are counted per specialist; when specialists flag the same line their findings are grouped into one inline comment, so the inline comment count is lower than this total. Code Review SummaryStatus: 4 Issues Found | Recommendation: see the Council Review decision above Overview
Issue Details (click to expand)WARNING
SUGGESTION
Files Reviewed (11 files)
Reviewed by grok-4.6 · Input: 244.8K · Output: 15.9K · Cached: 385.2K Review guidance: REVIEW.md from base branch |
de8779d to
bcf0d86
Compare
bcf0d86 to
c269f69
Compare
ba7ef42 to
8313fec
Compare
Stop embedding managed GitHub/GitLab/Bitbucket tokens in origin. A get-only helper reads GH_TOKEN / GITLAB_TOKEN / BITBUCKET_TOKEN so setup, submodules, and LFS work, and warm refresh is an env write.
8313fec to
6265c94
Compare
pandemicsyn
left a comment
There was a problem hiding this comment.
lgtm, one inline from my robot
Summary
This PR integrates Cloud Agent workspace setup with the credential-helper runtime shipped in #5445. The helper itself is not introduced here.
session.execso the sandbox's enforcedGIT_CONFIG_*environment reaches Git and the existing get-only helper supplies managed GitHub/GitLab/Bitbucket credentials.originURLs canonical and credential-free across cold clone, warm workspace setup, restore, and wrapper bootstrap; refresh managed auth through the session environment instead of rewriting URLs with tokens.Test plan
pnpm exec vitest run src/kilo-git-credential.test.ts src/workspace.test.ts src/session-service.test.ts(192 passed)bun test src/session-bootstrap.test.ts(56 passed)git ls-remote/ submodule / LFS still auth via the shipped helpergit.example.comremote still clones with an embedded token