Skip to content

feat(web-env): store staging secrets in 1Password - #5335

Merged
RSO merged 1 commit into
mainfrom
web-env-staging-1password
Aug 18, 2026
Merged

feat(web-env): store staging secrets in 1Password#5335
RSO merged 1 commit into
mainfrom
web-env-staging-1password

Conversation

@RSO

@RSO RSO commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Summary

CleanShot 2026-08-18 at 13 33 20@2x
  • store sensitive Staging values in the same 1Password item as Production using a concealed password (staging) field
  • allow either Staging or Production to create the item first, then add the missing environment field later
  • preserve and update existing Staging fields by label even when 1Password generated their field ID
  • document the combined item layout and expand focused 1Password template coverage

@kilo-code-bot

kilo-code-bot Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Executive Summary

Reviewed all 4 changed files of this stacked PR (based on #5334): the VaultEnvironment split of setVaultValue, the staging/production field helpers, the index.ts vault loop, and the expanded 1Password template tests and docs are internally consistent, correctly handle all create/edit field combinations, and introduce no leaks, security issues, or logic errors in changed code.

Files Reviewed (4 files)
  • DEVELOPMENT.md
  • scripts/web-env/index.ts
  • scripts/web-env/shared.test.ts
  • scripts/web-env/shared.ts

Reviewed by kimi-k3 · Input: 42.3K · Output: 6.2K · Cached: 321K

Review guidance: REVIEW.md from base branch iterate-on-webenv-command-2

Base automatically changed from iterate-on-webenv-command-2 to main August 18, 2026 11:43
@RSO
RSO force-pushed the web-env-staging-1password branch from d0579ee to c129143 Compare August 18, 2026 11:46
@RSO
RSO merged commit 25ce71b into main Aug 18, 2026
13 of 14 checks passed
@RSO
RSO deleted the web-env-staging-1password branch August 18, 2026 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants