feat(sessions): add shared sessions list filter - #5332
Conversation
Add an All/Shared filter on the Sessions page, with copy-link and unshare actions for published sessions.
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryIncremental review of commit Files Reviewed (6 files)
Previous Review Summary (commit a9e7d24)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit a9e7d24)Status: 1 Issue Found | Recommendation: Address before merge Executive SummarySolid, well-tested shared-sessions filter with owner-only unshare correctly mapped through the session-ingest worker; the only finding is a minor UI state race in the row-action pending indicator. Overview
Issue Details (click to expand)SUGGESTION
Files Reviewed (6 files)
Reviewed by kimi-k3 · Input: 106.1K · Output: 4.2K · Cached: 155.8K Review guidance: REVIEW.md from base branch |
A single pendingSessionId slot cleared the first-finishing action and re-enabled another row while its copy/unshare was still in flight.
Summary
Add an All/Shared filter on the Sessions page so users can find published sessions and manage their share links.
cliSessionsV2.list/searchacceptsharedOnly(public_id IS NOT NULL)cliSessionsV2.unshareis owner-only and maps worker 404 toNOT_FOUNDVerification
/cloud/sessions: All shows published + private, no row actionspublic_idand empties SharedVisual Changes
Reviewer Notes
public_idis still omitted from list/search payloadsshare; local copy needsSESSION_SHARE_JWT_SECRET_PRODon session-ingest