Skip to content

feat(sessions): add shared sessions list filter - #5332

Merged
eshurakov merged 2 commits into
mainfrom
eshurakov/polished-orca
Aug 18, 2026
Merged

feat(sessions): add shared sessions list filter#5332
eshurakov merged 2 commits into
mainfrom
eshurakov/polished-orca

Conversation

@eshurakov

@eshurakov eshurakov commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Summary

Add an All/Shared filter on the Sessions page so users can find published sessions and manage their share links.

  • cliSessionsV2.list / search accept sharedOnly (public_id IS NOT NULL)
  • cliSessionsV2.unshare is owner-only and maps worker 404 to NOT_FOUND
  • Shared rows expose Copy link and Unshare; All stays unchanged
  • Tokens are minted only when Copy link is used

Verification

  • Fake-login to /cloud/sessions: All shows published + private, no row actions
  • Shared shows only the published session with Copy link / Unshare
  • Copy link toasts "Link copied to clipboard"
  • Unshare confirm: "Anyone with the link will lose access." Confirming clears public_id and empties Shared
  • Shared search empty copy: "No sessions found matching your search."

Visual Changes

shared-sessions-all-clean shared-sessions-copy-clean shared-sessions-unshare-clean

Reviewer Notes

  • public_id is still omitted from list/search payloads
  • Copy link reuses existing share; local copy needs SESSION_SHARE_JWT_SECRET_PROD on session-ingest

Add an All/Shared filter on the Sessions page, with copy-link and
unshare actions for published sessions.
Comment thread apps/web/src/app/(app)/cloud/sessions/SessionsPageContent.tsx Outdated
@kilo-code-bot

kilo-code-bot Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Executive Summary

Incremental review of commit 4d30cbc confirms the previously reported pending-state race is fixed: row-action pending state is now tracked per session in an immutable Set with add-on-start/delete-in-finally semantics, and no new issues were found in the changed code.

Files Reviewed (6 files)
  • apps/web/src/app/(app)/cloud/sessions/SessionsPageContent.tsx - 0 issues (previous finding resolved)
  • apps/web/src/components/cloud-agent/SessionsList.tsx - 0 issues
  • apps/web/src/lib/session-ingest-client.ts - 0 issues
  • apps/web/src/lib/session-ingest-client.test.ts - 0 issues
  • apps/web/src/routers/cli-sessions-v2-router.ts - 0 issues
  • apps/web/src/routers/cli-sessions-v2-router.test.ts - 0 issues
Previous Review Summary (commit a9e7d24)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit a9e7d24)

Status: 1 Issue Found | Recommendation: Address before merge

Executive Summary

Solid, well-tested shared-sessions filter with owner-only unshare correctly mapped through the session-ingest worker; the only finding is a minor UI state race in the row-action pending indicator.

Overview

Severity Count
CRITICAL 0
WARNING 0
SUGGESTION 1
Issue Details (click to expand)

SUGGESTION

File Line Issue
apps/web/src/app/(app)/cloud/sessions/SessionsPageContent.tsx 125 Single-slot pendingSessionId races when copy/unshare on different rows overlap, re-enabling buttons early
Files Reviewed (6 files)
  • apps/web/src/app/(app)/cloud/sessions/SessionsPageContent.tsx - 1 issue
  • apps/web/src/components/cloud-agent/SessionsList.tsx - 0 issues
  • apps/web/src/lib/session-ingest-client.ts - 0 issues
  • apps/web/src/lib/session-ingest-client.test.ts - 0 issues
  • apps/web/src/routers/cli-sessions-v2-router.ts - 0 issues
  • apps/web/src/routers/cli-sessions-v2-router.test.ts - 0 issues

Fix these issues in Kilo Cloud


Reviewed by kimi-k3 · Input: 106.1K · Output: 4.2K · Cached: 155.8K

Review guidance: REVIEW.md from base branch main

A single pendingSessionId slot cleared the first-finishing action and
re-enabled another row while its copy/unshare was still in flight.
@eshurakov
eshurakov merged commit c93fcb3 into main Aug 18, 2026
18 checks passed
@eshurakov
eshurakov deleted the eshurakov/polished-orca branch August 18, 2026 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants