fix(web): merge Kilo fields into referenced config schema - #5330
Merged
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryThe schema merge correctly handles both the inline-root and Files Reviewed (2 files)
Reviewed by kimi-k3 · Input: 50.3K · Output: 4.3K · Cached: 147.7K Review guidance: REVIEW.md from base branch |
johnnyeric
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upstream CLI schema now uses a root
$refto$defs.Config, so sibling root-level schema keywords are ignored by JSON Schema validators. Kilo-only configuration fields were therefore reported as unknown even though they were present in the response.Merge Kilo top-level fields, primary agents, and experimental fields into
$defs.Config.propertieswhen that referenced shape is present, while retaining the existing inline-root behavior and permission additions. The merge clones affected structures so upstream schema objects are preserved.Add regression coverage for both schema shapes, including strict
additionalProperties: falsebehavior and preservation of upstream agent and experimental properties.Fixes Kilo-Org/kilocode#13140