Skip to content

fix(web): merge Kilo fields into referenced config schema - #5330

Merged
marius-kilocode merged 1 commit into
mainfrom
fix-kilo-config-schema-issue
Aug 18, 2026
Merged

fix(web): merge Kilo fields into referenced config schema#5330
marius-kilocode merged 1 commit into
mainfrom
fix-kilo-config-schema-issue

Conversation

@marius-kilocode

@marius-kilocode marius-kilocode commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

The upstream CLI schema now uses a root $ref to $defs.Config, so sibling root-level schema keywords are ignored by JSON Schema validators. Kilo-only configuration fields were therefore reported as unknown even though they were present in the response.

Merge Kilo top-level fields, primary agents, and experimental fields into $defs.Config.properties when that referenced shape is present, while retaining the existing inline-root behavior and permission additions. The merge clones affected structures so upstream schema objects are preserved.

Add regression coverage for both schema shapes, including strict additionalProperties: false behavior and preservation of upstream agent and experimental properties.

Fixes Kilo-Org/kilocode#13140

@kilo-code-bot

kilo-code-bot Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Executive Summary

The schema merge correctly handles both the inline-root and $ref: '#/$defs/Config' upstream shapes, cloning all affected structures so upstream objects are not mutated, with solid regression coverage for both paths.

Files Reviewed (2 files)
  • apps/web/src/app/config.json/route.ts
  • apps/web/src/tests/cli-config-schema.test.ts

Reviewed by kimi-k3 · Input: 50.3K · Output: 4.3K · Cached: 147.7K

Review guidance: REVIEW.md from base branch main

@marius-kilocode
marius-kilocode merged commit f37b88d into main Aug 18, 2026
13 checks passed
@marius-kilocode
marius-kilocode deleted the fix-kilo-config-schema-issue branch August 18, 2026 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Published config schema built from upstream opencode rejects Kilo-only keys (commit_message, indexing, ...)

2 participants