Skip to content

feat(admin): show coding plan subscription identifiers - #5328

Merged
jeanduplessis merged 1 commit into
mainfrom
feat/admin-coding-plan-subscription-identifiers
Aug 18, 2026
Merged

feat(admin): show coding plan subscription identifiers#5328
jeanduplessis merged 1 commit into
mainfrom
feat/admin-coding-plan-subscription-identifiers

Conversation

@jeanduplessis

Copy link
Copy Markdown
Contributor

Summary

Show the inventory key ID and upstream plan ID for each Coding Plan subscription in the admin operations table.

Why this change is needed

Admins need these identifiers when investigating subscriptions and working with upstream provider records. Previously, the subscriptions table exposed only the subscription ID.

How this is addressed

  • Add both identifiers to the admin-only subscriptions response.
  • Display them together in a compact table column.
  • Provide a copy action for each available identifier and show an em dash when one is unavailable.
  • Cover the admin response contract with a router regression test.

Human Verification

  • Coding Plans router suite: 29 tests passed.

Reviewer Notes

Human Reviewer Flags

No notable items for human review beyond what the summary covers.

Code Reviewer Agent

Code Reviewer Notes
  • The upstream plan ID is selected through the existing inventory left join, so subscriptions without inventory remain supported.
  • The new identifiers are exposed only by the admin procedure.
  • Static typechecking, linting, formatting, and diff checks pass.

@kilo-code-bot

kilo-code-bot Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (3 files)
  • apps/web/src/app/admin/coding-plans/CodingPlansOperationsContent.tsx
  • apps/web/src/routers/coding-plans-router.test.ts
  • apps/web/src/routers/coding-plans-router.ts

Reviewed the admin subscriptions identifier display change with high confidence. The router exposes inventoryKeyId and upstreamPlanId only via the admin procedure using the existing inventory left join (null-safe for subscriptions without inventory), the table column count and colSpan updates (7 → 8) are consistent, the copyIdentifier refactor preserves existing copy behavior with correct promise handling (void on click handlers), and the new regression test is properly isolated via the suite's afterEach cleanup. No memory-leak vectors (listeners, intervals, or retained references) introduced.


Reviewed by kimi-k3 · Input: 134K · Output: 3.8K · Cached: 276K

Review guidance: REVIEW.md from base branch main

@jeanduplessis
jeanduplessis enabled auto-merge (squash) August 18, 2026 09:47
@jeanduplessis
jeanduplessis merged commit 250fd78 into main Aug 18, 2026
18 checks passed
@jeanduplessis
jeanduplessis deleted the feat/admin-coding-plan-subscription-identifiers branch August 18, 2026 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants