Skip to content

fix(mobile): match dashed thought row box to solid tool row box - #5318

Merged
iscekic merged 1 commit into
mainfrom
thought-spacing-5e62
Aug 18, 2026
Merged

fix(mobile): match dashed thought row box to solid tool row box#5318
iscekic merged 1 commit into
mainfrom
thought-spacing-5e62

Conversation

@iscekic

@iscekic iscekic commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

fix(mobile): match dashed thought row box to solid tool row box

What changed

A collapsed thought pill in the mobile cloud-agent transcript now sits the same visible distance from neighboring tool pills as two tool pills sit from each other.

User note

The thought pill between two tool rows no longer looks farther away than the tool rows look from each other. The dashed outline and the THOUGHT / THINKING label are unchanged.

Product note

The transcript row rhythm is now uniform: the dashed thought card reuses the solid tool card's radius, border width, and overflow clip, so the visible gutter matches the gap-2 spacing between tool rows.

Maintainer note

FixedPartRow drew two card shapes: the solid tool card used overflow-hidden rounded-lg border border-border, while the dashed thought card used rounded-xl border-[1.5px] border-dashed border-border. The thicker stroke and larger radius receded the visible ink from the layout edge on iOS. The dashed branch now reuses the solid outer box and keeps only border-dashed. A mounted test locks the dashed outer class.

Human steps

No human step is needed.

Visual Changes

This is a subtle 1px spacing adjustment (the dashed thought row now uses the solid row's rounded-lg radius and 1px border instead of rounded-xl and a 1.5px stroke). No screenshot is attached; the change is locked by a mounted class test and the iOS regression check passed.

The dashed FixedPartRow used rounded-xl and a 1.5px dashed stroke, which
receded the visible ink from the layout edge on iOS and made a collapsed
thought pill look farther from neighboring tool pills than those pills look
from each other. Reuse the solid outer box (overflow-hidden rounded-lg border)
and keep only border-dashed, so the visible gutter matches the gap-2 rhythm.
@iscekic
iscekic requested a review from jeanduplessis August 18, 2026 02:45
@iscekic iscekic self-assigned this Aug 18, 2026
@kilo-code-bot

kilo-code-bot Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Executive Summary

Reviewed the mobile FixedPartRow dashed-variant styling alignment and its new mounted test at HEAD 4f6e7bcd10dca709ee01ae7d289f4cb2f89877a3; the change is a minimal, correct className adjustment with a matching assertion test and introduces no memory-leak vectors (no new subscriptions, timers, or retained async handles).

Files Reviewed (2 files)
  • apps/mobile/src/components/agents/fixed-part-row.tsx
  • apps/mobile/src/components/agents/fixed-part-row.mounted.test.tsx

Reviewed by kimi-k3 · Input: 29.3K · Output: 2.7K · Cached: 130.6K

Review guidance: REVIEW.md from base branch main

@iscekic iscekic added the human-ready The PR is ready for human review. label Aug 18, 2026
@iscekic
iscekic merged commit 3226e75 into main Aug 18, 2026
18 checks passed
@iscekic
iscekic deleted the thought-spacing-5e62 branch August 18, 2026 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

human-ready The PR is ready for human review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants