Skip to content

fix(mobile): show full markdown read bodies - #5069

Merged
iscekic merged 1 commit into
mainfrom
tap-full-file-0f1a
Aug 5, 2026
Merged

fix(mobile): show full markdown read bodies#5069
iscekic merged 1 commit into
mainfrom
tap-full-file-0f1a

Conversation

@iscekic

@iscekic iscekic commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

User: Tapping a markdown read row now opens the details sheet with the full available markdown immediately. The removed “Tap to read the full file” prompt and nested reader are gone.

Product manager: Markdown read output now uses one direct sheet interaction, while image zoom and other tool output behavior remain unchanged.

Maintainer: The mobile read resolver now returns a full fence-balanced MarkdownBody. ReadMarkdownBody renders it with the existing selectable chat markdown component, and the obsolete modal and inline-cap fields were removed.

Human steps: No step is needed before or after merge.

Visual Changes: N/A

E2E: bot-e2e — scenario 1 gates direct full markdown rendering; scenario 2 checks the unchanged inline image path and can report a fixture block reason.

@iscekic iscekic self-assigned this Aug 5, 2026
@kilo-code-bot

kilo-code-bot Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Executive Summary

Reviewed the mobile read-tool markdown refactor (resolver rename/simplification, new ReadMarkdownBody sheet component, removal of the modal viewer and inline cap, and updated tests) with high confidence: no stale references to removed symbols, no orphaned exports, edge cases (empty file, error state, image reads, fence balancing) preserved and covered by tests, the detail sheet scrolls so full markdown is reachable, and no memory-leak vectors were introduced (new component is stateless; the deleted preview's modal state is gone).

Files Reviewed (8 files)
  • apps/mobile/src/components/agents/markdown-viewer-modal.tsx (deleted — no remaining references)
  • apps/mobile/src/components/agents/read-markdown-body.tsx (new)
  • apps/mobile/src/components/agents/read-markdown-body.test.ts (new)
  • apps/mobile/src/components/agents/read-markdown-preview.tsx (deleted — no remaining references)
  • apps/mobile/src/components/agents/read-tool-markdown.ts
  • apps/mobile/src/components/agents/read-tool-markdown.test.ts
  • apps/mobile/src/components/agents/tool-cards/read-tool-card.tsx
  • apps/mobile/src/components/agents/tool-cards/tool-card-output-cap.test.ts

Reviewed by kimi-k3 · Input: 83.6K · Output: 12K · Cached: 557.1K

Review guidance: REVIEW.md from base branch main

@iscekic iscekic added the human-ready The PR is ready for human review. label Aug 5, 2026
@iscekic
iscekic enabled auto-merge (squash) August 5, 2026 21:49
@iscekic
iscekic merged commit e7d9c47 into main Aug 5, 2026
21 checks passed
@iscekic
iscekic deleted the tap-full-file-0f1a branch August 5, 2026 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

human-ready The PR is ready for human review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants