fix(mobile): show the session-ended notice as a toast - #5054
Conversation
The sign-in page rendered "Your session ended. Please sign in again." in the page body. It now shows as a toast, and the page body holds only the sign-in form.
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryIncremental review of commit Files Reviewed (1 file)
Previous Review Summary (commit 9e02228)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 9e02228)Status: 1 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)SUGGESTION
The change is otherwise correct: the effect deps are right, the Fix these issues in Kilo Cloud Files Reviewed (1 files)
Reviewed by kimi-k3 · Input: 38.7K · Output: 5.1K · Cached: 244.7K Review guidance: REVIEW.md from base branch |
What
The sign-in page showed "Your session ended. Please sign in again." in the page body. It now shows as a toast.
How
login-screen.tsx: one effect firestoast(...)whensessionEndedis true.Textblock is removed, so the idle branch renders only the sign-in form.id: 'session-ended', so a remount of the login route replaces the toast instead of stacking a second one.sessionEndedlogic inauth-context.tsxis unchanged: only a refused refresh sets it, and a normal sign-out does not.Checks
pnpm typecheck,pnpm lint,pnpm format,pnpm check:unused— clean.pnpm vitest run src/components/login-screen.test.ts— 15 passed.