Skip to content

fix(mobile): show the session-ended notice as a toast - #5054

Merged
iscekic merged 2 commits into
mainfrom
login-session-toast-5107
Aug 5, 2026
Merged

fix(mobile): show the session-ended notice as a toast#5054
iscekic merged 2 commits into
mainfrom
login-session-toast-5107

Conversation

@iscekic

@iscekic iscekic commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

What

The sign-in page showed "Your session ended. Please sign in again." in the page body. It now shows as a toast.

How

  • login-screen.tsx: one effect fires toast(...) when sessionEnded is true.
  • The inline Text block is removed, so the idle branch renders only the sign-in form.
  • The toast carries id: 'session-ended', so a remount of the login route replaces the toast instead of stacking a second one.
  • sessionEnded logic in auth-context.tsx is unchanged: only a refused refresh sets it, and a normal sign-out does not.

Checks

  • pnpm typecheck, pnpm lint, pnpm format, pnpm check:unused — clean.
  • pnpm vitest run src/components/login-screen.test.ts — 15 passed.
  • No device run yet.

The sign-in page rendered "Your session ended. Please sign in again." in the page body. It now shows as a toast, and the page body holds only the sign-in form.
@iscekic iscekic self-assigned this Aug 5, 2026
@iscekic
iscekic requested a review from pandemicsyn August 5, 2026 17:55
Comment thread apps/mobile/src/components/login-screen.tsx Outdated
@kilo-code-bot

kilo-code-bot Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Executive Summary

Incremental review of commit 919baa3 (announce session-ended toast): the sole prior finding is resolved — the notice now uses announcingToast.warning, whose signature and module were verified, and no new issues were found in the changed code.

Files Reviewed (1 file)
  • apps/mobile/src/components/login-screen.tsx
Previous Review Summary (commit 9e02228)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit 9e02228)

Status: 1 Issues Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 0
SUGGESTION 1
Issue Details (click to expand)

SUGGESTION

File Line Issue
apps/mobile/src/components/login-screen.tsx 69 Plain toast is not screen-reader announced; consider the repo's announcingToast adapter for this forced sign-out notice

The change is otherwise correct: the effect deps are right, the id dedupe matches the stated remount behavior, no duplicate notification paths exist, no listeners/timers are introduced (no memory-leak surface), and the layout wrapper removal is safe under the parent's stretch alignment.

Fix these issues in Kilo Cloud

Files Reviewed (1 files)
  • apps/mobile/src/components/login-screen.tsx - 1 issue

Reviewed by kimi-k3 · Input: 38.7K · Output: 5.1K · Cached: 244.7K

Review guidance: REVIEW.md from base branch main

@iscekic
iscekic enabled auto-merge (squash) August 5, 2026 18:08
@iscekic
iscekic merged commit 4f72981 into main Aug 5, 2026
20 checks passed
@iscekic
iscekic deleted the login-session-toast-5107 branch August 5, 2026 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants