feat(mobile): polish session preferences and transcript - #5047
Conversation
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryIncremental review of the 4 files changed since the previous review (merge conflict resolution with main's auth hardening plus a test-mock fix): the PR's Files Reviewed (4 files, incremental)
Previous Review Summary (commit adf1ca8)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit adf1ca8)Status: No Issues Found | Recommendation: Merge Executive SummaryReviewed all 41 changed mobile files covering persisted session preferences, transcript time markers with visibility filtering, and uncapped tool output; the visibility extraction was verified line-by-line against the renderers it mirrors, the sign-out race fix is correct, and no memory leaks, dangling references, or logic errors were found. Files Reviewed (41 files)
Reviewed by kimi-k3 · Input: 58.7K · Output: 10.1K · Cached: 589.8K Review guidance: REVIEW.md from base branch |
Summary
Why
The session UI repeated timestamps, hid long tool output, and lacked persisted controls for session behavior.
How
Verification
pnpm formatpnpm typecheckpnpm lintpnpm check:unusedses_20910801062d332d33798ca7cb.session-keep-awake.test.ts; the operating-system idle timer is not observable in the simulator.auth-context.test.tsxand the deferred SecureStore read regression test.E2E
E2E: bot-e2e — iOS-only verification completed. The 300000-character sheet opened within the decision threshold, so no safety cap was added. The final-head re-verification passed after the main merge.
Visual Changes