Skip to content

feat(mobile): force efficient model as the dev default - #5018

Merged
iscekic merged 2 commits into
mainfrom
mobile-dev-default-model-e955
Aug 5, 2026
Merged

feat(mobile): force efficient model as the dev default#5018
iscekic merged 2 commits into
mainfrom
mobile-dev-default-model-e955

Conversation

@iscekic

@iscekic iscekic commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Summary

  • In development builds, always select kilo-auto/efficient for a new mobile session.
  • The dev default wins over the server preference, the local preference, and the organization default.
  • Release builds keep the current selection priority.
  • Add pure unit coverage for the full selection priority.

Why

Development sessions need one stable efficient model. A stale preference from an earlier
session must not change the dev default. Release builds must not change at all.

How

  • Extract the selection priority into a pure function, pickAutoSelectedModel.
  • Return kilo-auto/efficient first when __DEV__ is true and the catalog holds the model.
  • If the catalog does not hold the model, fall back to the release priority: server
    lastSelected, then the local persisted preference, then the organization default, then
    the first catalog entry.
  • Keep the existing hook loading gate and selection latch.

Verification

  • pnpm test from apps/mobile — passed, 330 files and 3041 tests.
  • pnpm typecheck from apps/mobile — passed.
  • pnpm lint from apps/mobile — passed.

E2E

Bot E2E verification uses an iOS development build and checks the fresh new-session picker.

Visual Changes

N/A — this change alters the selected model, not the picker layout.

@iscekic iscekic self-assigned this Aug 5, 2026
@kilo-code-bot

kilo-code-bot Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Executive Summary

Incrementally re-reviewed the follow-up commits that promote the dev-only kilo-auto/efficient default above every explicit override: the change matches the stated PR intent, the release-build priority is behavior-identical, the early return skips no side effects (all helpers are pure), the updated and new unit tests trace correctly against the implementation, and no memory leaks or breaking changes were introduced.

Files Reviewed (3 files)
  • apps/mobile/src/lib/hooks/auto-select-model.ts
  • apps/mobile/src/lib/hooks/auto-select-model.test.ts
  • apps/mobile/src/lib/hooks/use-auto-select-model.ts
Previous Review Summary (commit e0c26cf)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit e0c26cf)

Status: No Issues Found | Recommendation: Merge

Executive Summary

Reviewed the dev-only kilo-auto/efficient auto-selection fallback for mobile new sessions: the selection-priority extraction into pickAutoSelectedModel is behavior-preserving for release builds, the __DEV__ gate follows existing codebase patterns, the 11 new unit tests trace correctly against the implementation, and no memory leaks or breaking changes were introduced.

Files Reviewed (3 files)
  • apps/mobile/src/lib/hooks/auto-select-model.ts
  • apps/mobile/src/lib/hooks/auto-select-model.test.ts
  • apps/mobile/src/lib/hooks/use-auto-select-model.ts

Reviewed by kimi-k3 · Input: 119.9K · Output: 5.7K · Cached: 182.3K

Review guidance: REVIEW.md from base branch main

@iscekic iscekic added the human-ready The PR is ready for human review. label Aug 5, 2026
Move the kilo-auto/efficient dev default above the server, local, and
organization overrides. Release builds keep the previous priority.
@iscekic iscekic changed the title feat(mobile): default dev sessions to efficient model feat(mobile): force efficient model as the dev default Aug 5, 2026
@iscekic
iscekic merged commit 537acdd into main Aug 5, 2026
21 checks passed
@iscekic
iscekic deleted the mobile-dev-default-model-e955 branch August 5, 2026 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

human-ready The PR is ready for human review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants