Repository navigation
fix(mobile): agent session screen UX — keep-awake, sheets, composer, costs #4884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
a5521e8
fix(mobile): keep screen awake while agent works; animate subagent sh…
iscekic d891cb1
docs(mobile): reference kilo-design baseline in AGENTS.md (item 12)
iscekic 67acec5
fix(mobile): show Older activity residual in session context sheet
iscekic 4e20dd9
fix(mobile): disable native text selection inside message bubbles
iscekic 851e386
fix(mobile): slash menu separators + SheetHeader title ellipsis
iscekic 2981b47
fix(mobile): composer AppState restore, swipe-down dismiss, reliable …
iscekic 1add09b
docs(workflow): learning — CLI sessions read-only until TUI /remote r…
iscekic 7c6a8bb
fix(mobile): restore mirror-Text composer growth (item 26)
iscekic e43025a
fix(mobile): dismiss keyboard on Android EditText swipe-down (item 22)
iscekic e442877
fix(mobile): evaluate composer AppState refocus gate at fire time (it…
iscekic ee1e04d
Merge remote-tracking branch 'origin/main' into session-page-ux-8225
iscekic feaae22
chore: drop .kilo_workflow remnants after main merge
iscekic 2b7cfa9
fix(mobile): restore copy path for tool output and reasoning (item 13)
iscekic cfcb4f2
fix(mobile): bound child-sheet mount and keep-awake to their lifetimes
iscekic 2798265
fix(mobile): suppress sub-display Older-activity residuals (item 23)
iscekic 44bcf5a
fix(mobile): scope Android swipe-dismiss touch tracking by identifier…
iscekic 524c31b
fix(mobile): release child sheet after iOS dismiss
iscekic 39d33ef
fix(mobile): stop keep-awake after disconnect
iscekic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 13 additions & 0 deletions
13
apps/mobile/src/components/agents/bubble-text-selection-context.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| import { createContext, useContext } from 'react'; | ||
|
|
||
| /** | ||
| * Inside a message bubble the long-press opens the details sheet; native | ||
| * selection must stay off so the iOS callout cannot float over the sheet | ||
| * (extends the rationale at text-part-renderer.tsx:12-14). | ||
| */ | ||
| export const InMessageBubbleContext = createContext(false); | ||
|
|
||
| /** True when transcript text may use native selection (outside a message bubble). */ | ||
| export function useTranscriptTextSelectable(): boolean { | ||
| return !useContext(InMessageBubbleContext); | ||
| } |
15 changes: 15 additions & 0 deletions
15
apps/mobile/src/components/agents/chat-composer-input-height.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| import { describe, expect, it } from 'vitest'; | ||
|
|
||
| import { shouldEnableComposerInputScroll } from './chat-composer-input-height'; | ||
|
|
||
| const MIN = 44; | ||
| const MAX = 124; | ||
|
|
||
| describe('shouldEnableComposerInputScroll', () => { | ||
| it('is true at or above max and false below', () => { | ||
| expect(shouldEnableComposerInputScroll(MAX, MAX)).toBe(true); | ||
| expect(shouldEnableComposerInputScroll(MAX + 1, MAX)).toBe(true); | ||
| expect(shouldEnableComposerInputScroll(MAX - 1, MAX)).toBe(false); | ||
| expect(shouldEnableComposerInputScroll(MIN, MAX)).toBe(false); | ||
| }); | ||
| }); |
9 changes: 9 additions & 0 deletions
9
apps/mobile/src/components/agents/chat-composer-input-height.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| /** | ||
| * Shared "scrollable at max height" threshold for the agents chat composer. | ||
| * Mirror-Text (`useTextHeight`) owns growth measurement; this module keeps the | ||
| * gate used by the row's `scrollEnabled` and the composer's swipe-down pan. | ||
| */ | ||
|
|
||
| export function shouldEnableComposerInputScroll(height: number, maxHeight: number): boolean { | ||
| return height >= maxHeight; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.