Skip to content

fix(ai-gateway): honor direct BYOK reasoning flags - #4865

Merged
chrarnoldus merged 1 commit into
mainfrom
honor-direct-byok-reasoning
Jul 29, 2026
Merged

fix(ai-gateway): honor direct BYOK reasoning flags#4865
chrarnoldus merged 1 commit into
mainfrom
honor-direct-byok-reasoning

Conversation

@chrarnoldus

Copy link
Copy Markdown
Contributor

Summary

  • advertise the reasoning supported parameter only for Direct BYOK models carrying the reasoning flag
  • remove include_reasoning from all Direct BYOK model metadata
  • cover reasoning and non-reasoning catalog entries

Tests

  • pnpm --filter web test -- --runInBand src/lib/ai-gateway/providers/direct-byok/index.test.ts
  • pnpm --filter web typecheck
  • targeted oxlint and oxfmt --list-different checks

@chrarnoldus chrarnoldus self-assigned this Jul 29, 2026
@kilo-code-bot

kilo-code-bot Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Executive Summary

Reviewed the direct BYOK supported_parameters change and its accompanying test; the reasoning flag gating logic is correct and well covered.

Files Reviewed (2 files)
  • apps/web/src/lib/ai-gateway/providers/direct-byok/index.ts
  • apps/web/src/lib/ai-gateway/providers/direct-byok/index.test.ts

Reviewed by claude-sonnet-5 · Input: 12 · Output: 2.1K · Cached: 208.3K

Review guidance: REVIEW.md from base branch main

@chrarnoldus
chrarnoldus merged commit e91be8c into main Jul 29, 2026
16 checks passed
@chrarnoldus
chrarnoldus deleted the honor-direct-byok-reasoning branch July 29, 2026 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants