Skip to content

feat(ai-gateway): flag reasoning direct BYOK models - #4860

Merged
chrarnoldus merged 2 commits into
mainfrom
swanky-observation
Jul 29, 2026
Merged

feat(ai-gateway): flag reasoning direct BYOK models#4860
chrarnoldus merged 2 commits into
mainfrom
swanky-observation

Conversation

@chrarnoldus

@chrarnoldus chrarnoldus commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add a reasoning capability flag for direct BYOK models
  • derive reasoning from models.dev metadata and assume it for OpenAI-compatible model discovery
  • flag hardcoded recommended models and every BytePlus coding model
  • leave supported_parameters unchanged until a post-merge sync has populated existing model records

Tests

  • pnpm --filter web test -- --runInBand src/lib/ai-gateway/providers/direct-byok/sync-direct-byok.test.ts src/lib/ai-gateway/providers/direct-byok/index.test.ts
  • pnpm --filter web typecheck
  • targeted oxlint and oxfmt checks

@chrarnoldus chrarnoldus self-assigned this Jul 29, 2026
@kilo-code-bot

kilo-code-bot Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Executive Summary

Reviewed the incremental follow-up commit (1536ee18d..b38f5ebf0) that defers reasoning-based supported_parameters filtering and removes the now-obsolete conditional test; the change is a deliberate, correct simplification consistent with the PR description and introduces no bugs, security issues, or logic errors.

Files Reviewed (3 files)
  • apps/web/src/lib/ai-gateway/providers/direct-byok/byteplus-coding.ts
  • apps/web/src/lib/ai-gateway/providers/direct-byok/index.test.ts
  • apps/web/src/lib/ai-gateway/providers/direct-byok/index.ts
Previous Review Summary (commit 1536ee1)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit 1536ee1)

Status: No Issues Found | Recommendation: Merge

Executive Summary

Reviewed the reasoning-capability flag addition across direct BYOK provider definitions, the dynamic sync parser, and model conversion logic; no bugs, security issues, or logic errors were found in the changed lines.

Files Reviewed (21 files)
  • apps/web/src/lib/ai-gateway/providers/direct-byok/alibaba-token-plan.ts
  • apps/web/src/lib/ai-gateway/providers/direct-byok/byteplus-coding.ts
  • apps/web/src/lib/ai-gateway/providers/direct-byok/chutes-byok.ts
  • apps/web/src/lib/ai-gateway/providers/direct-byok/crofai.ts
  • apps/web/src/lib/ai-gateway/providers/direct-byok/inceptron-byok.ts
  • apps/web/src/lib/ai-gateway/providers/direct-byok/index.test.ts
  • apps/web/src/lib/ai-gateway/providers/direct-byok/index.ts
  • apps/web/src/lib/ai-gateway/providers/direct-byok/kimi-coding.ts
  • apps/web/src/lib/ai-gateway/providers/direct-byok/martian.ts
  • apps/web/src/lib/ai-gateway/providers/direct-byok/morph.ts
  • apps/web/src/lib/ai-gateway/providers/direct-byok/neurowatt.ts
  • apps/web/src/lib/ai-gateway/providers/direct-byok/ollama-cloud.ts
  • apps/web/src/lib/ai-gateway/providers/direct-byok/opencode-go.ts
  • apps/web/src/lib/ai-gateway/providers/direct-byok/orcarouter.ts
  • apps/web/src/lib/ai-gateway/providers/direct-byok/sync-direct-byok.test.ts
  • apps/web/src/lib/ai-gateway/providers/direct-byok/sync-direct-byok.ts
  • apps/web/src/lib/ai-gateway/providers/direct-byok/synthetic.ts
  • apps/web/src/lib/ai-gateway/providers/direct-byok/types.ts
  • apps/web/src/lib/ai-gateway/providers/direct-byok/xiaomi-token-plan-ams.ts
  • apps/web/src/lib/ai-gateway/providers/direct-byok/xiaomi-token-plan-sgp.ts
  • apps/web/src/lib/ai-gateway/providers/direct-byok/zai-coding.ts

Reviewed by claude-sonnet-5 · Input: 28 · Output: 5K · Cached: 782.1K

Review guidance: REVIEW.md from base branch main

@chrarnoldus
chrarnoldus merged commit 1b2803c into main Jul 29, 2026
16 checks passed
@chrarnoldus
chrarnoldus deleted the swanky-observation branch July 29, 2026 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants