Skip to content

feat(web): make local email capture browser-open configurable - #4854

Merged
iscekic merged 1 commit into
mainfrom
local-email-open-browser-config
Jul 29, 2026
Merged

feat(web): make local email capture browser-open configurable#4854
iscekic merged 1 commit into
mainfrom
local-email-open-browser-config

Conversation

@iscekic

@iscekic iscekic commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Locally captured emails (the dev outbox under dev/logs/emails/) always opened in a browser tab via open/xdg-open/explorer.exe.
  • New env var LOCAL_EMAIL_OPEN_BROWSER: set to false to keep captures on disk without popping a tab. Unset keeps the current behavior (opens).
  • Documented in ENVIRONMENT.md; covered by a new unit test.

Test plan

  • pnpm --filter web exec jest src/lib/email-local-outbox.test.ts — 4/4 pass (default opens, false suppresses, open-failure still captures, metadata escaping).

…AL_EMAIL_OPEN_BROWSER

Locally captured emails (dev outbox) always opened in a browser tab.
Set LOCAL_EMAIL_OPEN_BROWSER=false to keep the capture on disk under
dev/logs/emails/ without popping a tab. Defaults to current behavior.
@iscekic iscekic self-assigned this Jul 29, 2026
@kilo-code-bot

kilo-code-bot Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Executive Summary

Reviewed the new LOCAL_EMAIL_OPEN_BROWSER opt-out for local email capture with high confidence; the gating logic, test coverage, and documentation are all correct.

Files Reviewed (3 files)
  • ENVIRONMENT.md
  • apps/web/src/lib/email-local-outbox.ts
  • apps/web/src/lib/email-local-outbox.test.ts

Reviewed by claude-sonnet-5 · Input: 16 · Output: 2.2K · Cached: 278.5K

Review guidance: REVIEW.md from base branch main

@iscekic
iscekic requested a review from jeanduplessis July 29, 2026 10:21
@iscekic
iscekic enabled auto-merge (squash) July 29, 2026 10:21
@iscekic
iscekic merged commit f2e1dd5 into main Jul 29, 2026
17 checks passed
@iscekic
iscekic deleted the local-email-open-browser-config branch July 29, 2026 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants