Skip to content

fix(web): add web search CLI config schema - #4798

Merged
lambertjosh merged 2 commits into
mainfrom
feat/web-search-config-schema
Jul 29, 2026
Merged

fix(web): add web search CLI config schema#4798
lambertjosh merged 2 commits into
mainfrom
feat/web-search-config-schema

Conversation

@lambertjosh

@lambertjosh lambertjosh commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Adds the top-level web_search option to the public Kilo CLI JSON Schema served from app.kilo.ai/config.json. It defaults to false, matching the existing managed-provider-only behavior; users opt in to third-party-provider search with web_search: true.

This endpoint is an editor-validation schema overlay, not a Cloud settings surface. Without this entry, users configuring the option introduced by Kilo-Org/kilocode#12369 receive a false unknown-property warning from $schema validation.

Companion to Kilo-Org/kilocode#12369

@kilo-code-bot

kilo-code-bot Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Executive Summary

Follow-up commit flips the web_search schema default from true to false and keeps the description and test assertion consistent with the new default; no bugs or security issues found in the changed lines.

Files Reviewed (2 files)
  • apps/web/src/app/config.json/extras.ts
  • apps/web/src/tests/cli-config-schema.test.ts
Previous Review Summary (commit 76fb8db)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit 76fb8db)

Status: No Issues Found | Recommendation: Merge

Executive Summary

Small, well-scoped addition of the web_search top-level schema entry mirroring existing patterns (e.g. openTelemetry), with a matching test assertion; no bugs or security issues found in the changed lines.

Files Reviewed (2 files)
  • apps/web/src/app/config.json/extras.ts
  • apps/web/src/tests/cli-config-schema.test.ts

Reviewed by claude-sonnet-5 · Input: 22 · Output: 3.9K · Cached: 433.6K

Review guidance: REVIEW.md from base branch main

@lambertjosh
lambertjosh merged commit db42ad7 into main Jul 29, 2026
15 checks passed
@lambertjosh
lambertjosh deleted the feat/web-search-config-schema branch July 29, 2026 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants