-
Notifications
You must be signed in to change notification settings - Fork 9
docs(mobile): workflow learnings log and planner simplicity mandate #4782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
5e51271
docs(mobile): add workflow learnings log and read/write contract
iscekic e0e4fa1
docs(mobile): planner simplicity mandate in workflow and plan reviewer
iscekic c17ca0a
docs(mobile): add machine-global device-slot semaphore for parallel w…
iscekic 491331a
fix(mobile): only reap device slots when tmux can actually report liv…
iscekic 26a1047
docs(mobile): harden Android emulator runbook against boot flailing
iscekic 6dd36e1
docs(mobile): trust role-agent instructions over permission enforcement
iscekic c9b6e72
docs(mobile): fix device-slot command path and add slot release to e2…
iscekic 5570103
docs(mobile): align learnings log intro with writer contract
iscekic ebc0080
docs(mobile): keep emulator evidence after process death via tee log
iscekic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| # Workflow Learnings | ||
|
|
||
| Environment blockers and their fixes, recorded by the planner or orchestrator for the role that hit them. The full contract — when to read, when to write, entry shape, deduplication — is in [MOBILE_WORKFLOW.md](MOBILE_WORKFLOW.md). | ||
|
|
||
| ## Planner | ||
|
|
||
| ## Orchestrator |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WARNING: Removing permission-level enforcement for reviewer/verifier roles widens prompt-injection blast radius
This commit removes
edit: deny/ restrictedbashallowlists frommobile-plan-reviewer.mdandmobile-reviewer.md(nowedit: allowandbash: "*": allow), and drops thegit commit/push,gh pr*, andsocatdenies frommobile-implementer.mdandmobile-e2e-verifier.md. The rationale documented here (deny lists caused void review rounds) is reasonable, but these reviewer/verifier roles read untrusted content as part of their job — plan files, diffs, and repository files that could contain injected instructions. Previously, permissions provided a technical backstop even if the model followed injected instructions to edit, commit, or push; now that backstop is gone and the only defense is the system-prompt instruction not to. Worth confirming this tradeoff is intentional and acceptable for this workflow, since a successful prompt injection can now actually mutate the repository or push/open a PR instead of merely being blocked at the permission layer.Reply with
@kilocode-bot fix itto have Kilo Code address this issue.