Mobile: theme setting + session row unification - #4729
Merged
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryIncremental review of the latest commits (cost-segment addition to Files Reviewed (5 files)
Previous Review Summary (commit c87867b)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit c87867b)Status: 1 Issue Found | Recommendation: Address before merge Executive SummaryThe Home-screen session-row refactor drops the live-status indicator for stored cloud-agent sessions that are currently active. Overview
Issue Details (click to expand)WARNING
Files Reviewed (12 files)
Reviewed by claude-sonnet-5 · Input: 24 · Output: 5.3K · Cached: 545.7K Review guidance: REVIEW.md from base branch |
jeanduplessis
approved these changes
Jul 24, 2026
…-session-row # Conflicts: # apps/mobile/src/components/agents/session-row-actions.ts # apps/mobile/src/components/agents/session-row.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two client-only mobile features:
1. Theme setting (Light / Dark / System)
theme-preference(default System, survives sign-out) via the existingcreateSecureStorePreference.Appearance.setColorScheme(...)call, which drives NativeWindclassNametokens,useThemeColors()/useNavigationTheme(), the status bar, and every otheruseColorScheme()consumer — souse-theme-colors.tsis untouched.RootLayoutNavholds the splash until the stored preference has loaded and been applied (the apply effect runs beforeSplashScreen.hideAsync()).SegmentedControl), reflecting the stored preference and firing a selection haptic on change.2. Session row unification
StoredSessionRow/RemoteSessionRowwrappers withvariant('list'|'card') andinteractive, and migrates the Home "Agent sessions" section onto them so Home and the Agents list render through the same wrappers.Intended behavior changes
updated_at-based.Non-goals
No backend/tRPC/schema/shared-package changes, no new theme tokens, no long-press menu on Home, no new dependencies.
Testing
pnpm typecheck,pnpm lint,pnpm check:unused,pnpm format:check,pnpm test(1678 passing) all green.