feat(code reviewer) Begin deprecation of code review custom instructions - #4679
Merged
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryReviewed the deprecation of the Custom Instructions field across web and mobile config forms; the show-once-set gating logic and REVIEW.md links are consistent and no bugs were found in the changed lines. Files Reviewed (4 files)
Reviewed by claude-sonnet-5 · Input: 18 · Output: 3.2K · Cached: 431.3K Review guidance: REVIEW.md from base branch |
jrf0110
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Starts deprecating the code reviewer's Custom Instructions field in favor of REVIEW.md. The field no longer renders for configs that have never used it. Configs that already have a value keep the field, with a note pointing them to REVIEW.md.
UI only. The schema, tRPC routers, and prompt generation are untouched, so stored custom instructions are still saved and still applied to reviews.
Changes
ReviewConfigForm.tsx(GitHub and GitLab, org and personal scopes): gate the Custom Instructions block behind newshowCustomInstructionsstate, set on config load when the stored value is non-empty. The old helper text ("Add specific guidelines for your team's code review standards") is replaced by the deprecation note plus a link to the existing REVIEW.md guide page.BitbucketReviewConfigForm.tsx: same gating and note for Bitbucket's separate custom instructions field, which had no helper text before.platform-overview-rows.ts(mobile): drop the Custom Instructions row from the provider overview when nothing is stored, which also removes the only route to the edit screen. The subtitle is now always "Set", since the row only renders when a value exists.instructions.tsx(mobile edit screen): same note above the input.Wording is identical on all three surfaces:
Verification
pnpm --filter web typecheck,pnpm lintinapps/mobile, andoxfmt. The conditional rendering still needs a pass against one config with a stored value and one without.Visual Changes
Reviewer Notes
reviewMdGuideHref, which already covers both scopes.ReviewMdGuideContent.tsx:30). That reads oddly as the destination of a deprecation notice.