Skip to content

config schema: add privacy_mode to kiloExtras top bucket - #4658

Merged
johnnyeric merged 1 commit into
Kilo-Org:mainfrom
IamCoder18:config-privacy-mode
Aug 5, 2026
Merged

config schema: add privacy_mode to kiloExtras top bucket#4658
johnnyeric merged 1 commit into
Kilo-Org:mainfrom
IamCoder18:config-privacy-mode

Conversation

@IamCoder18

@IamCoder18 IamCoder18 commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Add privacy_mode to the top bucket of apps/web/src/app/config.json/extras.ts so editors using https://app.kilo.ai/config.json don't flag it as an unknown property. Also adds the matching assertion in cli-config-schema.test.ts to keep schema-sync enforcement green.

Related: Kilo-Org/kilocode#12442

@kilo-code-bot

kilo-code-bot Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Executive Summary

Re-reviewed at the rebased head: the PR still only adds the privacy_mode boolean to the kiloExtras.top schema bucket with matching test assertions (the adjacent web_search entry comes from main, not this PR); no issues found.

Files Reviewed (2 files)
  • apps/web/src/app/config.json/extras.ts
  • apps/web/src/tests/cli-config-schema.test.ts
Previous Review Summary (commit d3e4f9d)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit d3e4f9d)

Status: No Issues Found | Recommendation: Merge

Executive Summary

This PR adds the privacy_mode boolean key to the kiloExtras.top schema bucket with a matching test assertion, consistent with existing patterns; no issues found.

Files Reviewed (2 files)
  • apps/web/src/app/config.json/extras.ts
  • apps/web/src/tests/cli-config-schema.test.ts

Reviewed by kimi-k3 · Input: 120.2K · Output: 6.6K · Cached: 161.8K

Review guidance: REVIEW.md from base branch main

@johnnyeric

Copy link
Copy Markdown
Contributor

Hey @IamCoder18, thanks for the PR, could you solve the conflicts?

@IamCoder18
IamCoder18 force-pushed the config-privacy-mode branch from d3e4f9d to cba5464 Compare August 5, 2026 13:27
@IamCoder18

Copy link
Copy Markdown
Contributor Author

Hey @IamCoder18, thanks for the PR, could you solve the conflicts?

Fixed.

@johnnyeric
johnnyeric merged commit be1c123 into Kilo-Org:main Aug 5, 2026
16 checks passed
@johnnyeric

Copy link
Copy Markdown
Contributor

Thanks for the quick response @IamCoder18, merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants