Skip to content

fix(cloud-agent-next): preserve wrapper cleanup backoff - #3626

Merged
eshurakov merged 2 commits into
mainfrom
fix/cloud-agent-next-cleanup-backoff
Jun 1, 2026
Merged

fix(cloud-agent-next): preserve wrapper cleanup backoff#3626
eshurakov merged 2 commits into
mainfrom
fix/cloud-agent-next-cleanup-backoff

Conversation

@eshurakov

@eshurakov eshurakov commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Follow-up to #3555

  • Preserve the persisted physical-wrapper cleanup deadline while explicit session deletion waits for verified wrapper absence, avoiding one-second retry churn that discards lease backoff.
  • Remove the obsolete out-of-band SessionService.interrupt provider-kill stack and stale router-test scaffolding now that interruption routes through Durable Object-owned physical teardown.
  • Add integration coverage proving explicit deletion retains the wrapper lease retry deadline.

Comment thread services/cloud-agent-next/test/integration/session/deletion-lifecycle.test.ts Outdated
@kilo-code-bot

kilo-code-bot Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Executive Summary

All previously flagged issues have been resolved; the new commit removes the redundant expect(result.lease.state).toBe('stop_needed') assertion as suggested.

Files Reviewed (5 files)
  • services/cloud-agent-next/src/persistence/CloudAgentSession.ts — no issues
  • services/cloud-agent-next/src/router.test.ts — no issues
  • services/cloud-agent-next/src/session-service.ts — no issues
  • services/cloud-agent-next/test/integration/session/deletion-lifecycle.test.ts — previous SUGGESTION resolved ✓

Reviewed by claude-4.6-sonnet-20260217 · 168,855 tokens

Review guidance: REVIEW.md from base branch main

@eshurakov
eshurakov merged commit 1a0c430 into main Jun 1, 2026
13 checks passed
@eshurakov
eshurakov deleted the fix/cloud-agent-next-cleanup-backoff branch June 1, 2026 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants