Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue when FIFO PopFirst call resurns incorrect value; it was h… #756

Closed
wants to merge 1 commit into from

Conversation

proteamer
Copy link

…appening when number of PopFirst call exceeds allocated FIFO size.

I'm not sure that it's right repo for PR but I hope to get some help here.

I tried to convert my 3d models with collada2gltf -f model.dae -o compressed -k -c Open3DGC -m binary . And faced with problem when compression for some models caused errors like this:

collada2gltf: /home/vagrant/dev/glTF/COLLADA2GLTF/dependencies/o3dgc/src/o3dgc_common_lib/inc/o3dgcAdjacencyInfo.h:123: long int o3dgc::AdjacencyInfo::Begin(long int) const: Assertion 'element < m_numElements' failed.

I figured out the reasons of that error and fix it (see 3f58ffc) after that I checked my models but there was second error: Segmentation fault.

After some time of my research I found the main reason of error it was const long O3DGC_MAX_TFAN_SIZE = 256; limitation see code: link#1 and link#2. But TFAN size for my models could reach 4k.

So my question is whtat is thre right way to fix it? I suppose to compute O3DGC_MAX_TFAN_SIZE value for particular case.

Thanks for attention.

…appening when number of PopFirst call exceeds allocated FIFO size
@pjcozzi
Copy link
Member

pjcozzi commented Oct 27, 2016

@proteamer are you picking up the work in #398? That would be amazing!

You are right that this is not the right source repo for Open3DGC. It might be here: https://github.com/amd/rest3d/tree/master/server/o3dgc

@kmammou would know.

@proteamer
Copy link
Author

@pjcozzi thanks for reply. I've made the duplicate PR

And I'm interested in mesh_compression_open3dgc extention and I'll look into #398.

@lexaknyazev
Copy link
Member

Closed, due to moving COLLADA2GLTF into separate repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants