Fixed issue when FIFO PopFirst call resurns incorrect value; it was h… #756
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…appening when number of PopFirst call exceeds allocated FIFO size.
I'm not sure that it's right repo for PR but I hope to get some help here.
I tried to convert my 3d models with
collada2gltf -f model.dae -o compressed -k -c Open3DGC -m binary
. And faced with problem when compression for some models caused errors like this:collada2gltf: /home/vagrant/dev/glTF/COLLADA2GLTF/dependencies/o3dgc/src/o3dgc_common_lib/inc/o3dgcAdjacencyInfo.h:123: long int o3dgc::AdjacencyInfo::Begin(long int) const: Assertion 'element < m_numElements' failed.
I figured out the reasons of that error and fix it (see 3f58ffc) after that I checked my models but there was second error:
Segmentation fault
.After some time of my research I found the main reason of error it was
const long O3DGC_MAX_TFAN_SIZE = 256;
limitation see code: link#1 and link#2. ButTFAN
size for my models could reach 4k.So my question is whtat is thre right way to fix it? I suppose to compute
O3DGC_MAX_TFAN_SIZE
value for particular case.Thanks for attention.