Add -Wconversion and fix the related conversion issues #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dabrain34
force-pushed
the
dab_fix_conversion
branch
from
5cfbe9c to
64769ce
Compare
|
@zlatinski Can you give a glance to this PR. It allows to avoid non regression when we change something in vulkan-video-samples. I had the issue today again with CTS bots failing because of Vulkan-Video-Samples. This is quite a big change but necessary. |
zlatinski
requested changes
Dec 18, 2024
There was a problem hiding this comment.
Thank you, Stephane, for these changes. These look good in general, but I would like to request a bit more improvements. If you want, you can change the VP9 types to concrete, but you don't have to at this point because we are updating the parser based on the latest Vulkan VP9 spec, anyway.
vk_video_decoder/libs/NvVideoParser/src/NextStartCodeAVX512.cpp
Outdated
Show resolved
Hide resolved
dabrain34
force-pushed
the
dab_fix_conversion
branch
2 times, most recently
from
b184ffc to
c18a749
Compare
zlatinski
requested changes
Dec 19, 2024
dabrain34
force-pushed
the
dab_fix_conversion
branch
from
c18a749 to
ba1547b
Compare
Due to -Wconversion, a lot of conversion have been discovered.
As -1 is not shaderc_shader_kind, use the default one as shaderc_glsl_infer_from_source. Conversion issue.
Change to 255
dabrain34
force-pushed
the
dab_fix_conversion
branch
from
ba1547b to
2cd1ba3
Compare
dabrain34
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.