Skip to content

verify_submission.py: delay git clone #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

totalspectrum
Copy link

Cloning the VK-GL-CTS repository can take a long time, so defer doing that until at least some of the sanity checks have been done (e.g. that we know the tar file is legal). This prevents the user from having to wait 5 minutes (or longer!) to discover that they've mistyped the file name.

Cloning the VK-GL-CTS repository can take a long time, so defer
doing that until at least some of the sanity checks have been done
(e.g. that we know the tar file is legal). This prevents the user
from having to wait 5 minutes (or longer!) to discover that they've
mistyped the file name.
@CLAassistant
Copy link

CLAassistant commented Jun 23, 2024

CLA assistant check
All committers have signed the CLA.

@dgkoch
Copy link

dgkoch commented Jun 24, 2024

If you have a local copy of the repo checked out, you can also use the -s argument to avoid cloning it completely.

I'm not necessarily objecting to the proposed change, but if you have a local repository, the new flow is worse if you got the tar name correct, but the source folder incorrect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants