spirv-val: Add DotProduce Capability#6525
Merged
alan-baker merged 2 commits intoKhronosGroup:mainfrom Feb 2, 2026
Merged
Conversation
alan-baker
reviewed
Feb 1, 2026
|
Thanks @spencer-lunarg ! This should fix the failures we've seen in LLVM upstream buildbots. https://github.com/llvm/llvm-project/actions/runs/21590282003/job/62208420883 |
Contributor
Author
|
@jmmartinez the error I see is that won't be fixed here, that is a bug in the spirv output of LLVM, the spec says
and assume |
Thanks ! I've missed the part of adding |
alan-baker
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


I realized in #6524 I forgot the validation around
DotProductInputAll,DotProductInput4x8BitandDotProductInput4x8BitPacked