Skip to content

spirv-val: Add DotProduce Capability#6525

Merged
alan-baker merged 2 commits intoKhronosGroup:mainfrom
spencer-lunarg:spencer-lunarg-dot-product-cap
Feb 2, 2026
Merged

spirv-val: Add DotProduce Capability#6525
alan-baker merged 2 commits intoKhronosGroup:mainfrom
spencer-lunarg:spencer-lunarg-dot-product-cap

Conversation

@spencer-lunarg
Copy link
Contributor

I realized in #6524 I forgot the validation around DotProductInputAll, DotProductInput4x8Bit and DotProductInput4x8BitPacked

@jmmartinez
Copy link

Thanks @spencer-lunarg ! This should fix the failures we've seen in LLVM upstream buildbots. https://github.com/llvm/llvm-project/actions/runs/21590282003/job/62208420883

@spencer-lunarg
Copy link
Contributor Author

@jmmartinez the error I see is

# | error: line 20: 'Vector 1' and 'Vector 2' are a 32-bit int scalar, but no Packed Vector Format was provided.
# |   %8 = OpUDot %uint %x %y

that won't be fixed here, that is a bug in the spirv output of LLVM, the spec says

image

and assume %x here is a scalar by the message, it is missing the optional PackedVectorFormat4x8Bit operand (which I assume has "just worked" as its the only option currently)

@jmmartinez
Copy link

@jmmartinez the error I see is

# | error: line 20: 'Vector 1' and 'Vector 2' are a 32-bit int scalar, but no Packed Vector Format was provided.
# |   %8 = OpUDot %uint %x %y

that won't be fixed here, that is a bug in the spirv output of LLVM, the spec says

image and assume `%x` here is a scalar by the message, it is missing the optional `PackedVectorFormat4x8Bit` operand (which I assume has "just worked" as its the only option currently)

Thanks ! I've missed the part of adding PackedVectorFormat4x8Bit. I'll get some time to fix that tomorrow.

@alan-baker alan-baker merged commit a66a95e into KhronosGroup:main Feb 2, 2026
22 checks passed
@spencer-lunarg spencer-lunarg deleted the spencer-lunarg-dot-product-cap branch February 2, 2026 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants